Require cloud build to succeed in make dist checks. #9218
Conversation
Manage this branch in SquashTest this branch here: https://ferroinrobust-dist-check-zf8pj.squash.io |
There was a problem hiding this comment.
LGTM. Just a thought though...
Should we refactor
.github/scripts/run_install_with_dist_file.shto accept arguments we can pass in from CI and have a few different things we can check? Not just assume that all checks will now ensure the Cloud functionality builds correctly, but other optional features as separate jobs?
I'd been thinking about this myself, but a lot more generically than just that. |
Ferroin
force-pushed
the
robust-dist-check
branch
from
aa01a8d
to
b8b8afa
Compare
|
@prologic Could you possibly take a look into the failures here, I'm stumped. It looks like for some reason |
prologic
force-pushed
the
robust-dist-check
branch
from
b8b8afa
to
3aa774a
Compare
|
@Ferroin You need to see what the dist build failures are. The CentOS 8.x failures are a KP and I'm working on them. Please have a look :) |
Ferroin
force-pushed
the
robust-dist-check
branch
3 times, most recently
from
bb336e4
to
101ff04
Compare
|
Dist check is still failing. Looks like missing |
The default behavior in `kickstart.sh` is to run `install-required-packages.sh` with just the `netdata` package set, and we don't even document how to make it run with `netdata-all`, so a vast majority of users will only be running using the `netdata` package set.
We should be testing our distfiles against our current version of `install-required-packages.sh`, not some pre-generated test image that we have to manage ina separaterepo. Also, disable telemetry for the test build so we don't accidentally pollute the stats.
Ferroin
force-pushed
the
robust-dist-check
branch
from
101ff04
to
a61fd9e
Compare
|
@prologic Finally got around to updating this and getting it working correctly, if you could take another look at it that would be appreciated. |
|
Merged on behalf of @Ferroin (while away on vacation); as this directly impacts our CI and improves it. |
Summary
This updates our
make distcheck to only pass if building with Netdata Cloud functionality succeeds.Component Name
area/ci
Test Plan
CI check passes on this PR.
Additional Information
Fixes: #8284