Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change instruction to reload HEALTH #9869

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

thiagoftsm
Copy link
Contributor

Summary

@amoss wrote something that we missed when we brought netdatacli, so I am bringing this PR to update our documentation related to health.

Component Name

Doc

Test Plan
Additional Information

@squash-labs
Copy link

squash-labs bot commented Sep 2, 2020

Manage this branch in Squash

Test this branch here: https://thiagoftsmnetdatacli-instead-k-h8xf3.squash.io

joelhans
joelhans previously approved these changes Sep 2, 2020
Copy link
Contributor

@joelhans joelhans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, very nice. This is much cleaner than using killall!

@ilyam8
Copy link
Member

ilyam8 commented Sep 2, 2020

Just sharing my exp.: netdatacli is not always in the PATH. Using killall is quite handy in that case.

@amoss
Copy link
Contributor

amoss commented Sep 2, 2020

Do we know the absolute path of netdatacli when we generate notifications?

@thiagoftsm
Copy link
Contributor Author

@ilyam8 I talked with @joelhans and we are now centralizing the information to reload Health and creating links to it.

Yes @amoss , we always know its position, because it is inserted at ${NETDATA_PREFIX}/usr/bin, but considering that this is documentation, @joelhans and I moved in a direction to show both options centralized to simplify user's life when they are looking for some information.

@thiagoftsm thiagoftsm merged commit f57c6c0 into netdata:master Sep 10, 2020
@thiagoftsm thiagoftsm deleted the netdatacli_instead_killall branch September 10, 2020 13:10
joelhans pushed a commit to joelhans/netdata that referenced this pull request Sep 16, 2020
Add netdatacli as instruction to reload health.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants