Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

device addresses report has broken column data #552

Closed
ollyg opened this issue Mar 26, 2019 · 2 comments
Closed

device addresses report has broken column data #552

ollyg opened this issue Mar 26, 2019 · 2 comments

Comments

@ollyg
Copy link
Member

ollyg commented Mar 26, 2019 

11:37 <inphobia> so, yesterday i was looking into why my fortinets were missing an interface, got sidetracked, and started wondering about this:
11:37 <inphobia> if you go to device details->addresses, there a "description column"
11:37 <inphobia> for non of the devices i checked this is filled in
11:38 <inphobia> according to the .tt it should reference "name", but device_ip does not contain a "name" field
11:40 <inphobia> for the csv .tt however it references row.device_port.name , however also that isn't populated in the csv files i downloaded
11:41 <inphobia> so, i'm kinda doubting that the query from web/plugin/device/addresses even returns the needed info...
@inphobia
Copy link
Member

query according to dbic debug:

SELECT me.ip, me.alias, me.subnet, me.port, me.dns, me.creation
  FROM device_ip me
WHERE me.ip = '10.40.254.26'
ORDER BY alias

@ollyg
Copy link
Member Author

ollyg commented Apr 1, 2019

thanks! fixed in:
[master 3e15410] #552 device addresses report has broken column data

@ollyg ollyg closed this as completed Apr 1, 2019
ollyg added a commit that referenced this issue Apr 1, 2019
@ollyg
#552 device addresses report has broken column data
3e15410
rc9000 added a commit to rc9000/netdisco that referenced this issue Aug 20, 2019
@rc9000
Merge remote-tracking branch 'upstream/master'
a090094 
* upstream/master: (178 commits)
  fix for netdisco#633
  fix for netdisco#633
  fix for netdisco#633
  add relation to get latest node on port
  netdisco#624 device layers search should be OR (not AND)
  show how to package own radius dictionary files
  netdisco#630 display full oui vendor
  improvements to radius patch
  Modified to add Radius support (netdisco#621)
  typo
  typos
  typo
  typo
  typo
  typo
  typo
  typo
  typos
  typo
  typo
  Change Port Free icon to be more accessible (netdisco#633)
  you really need to install the packages we ask
  fix travis
  make sidebar tiny bit wider (netdisco#625)
  compare ieee mac against 6 iterations (netdisco#611)
  add poe on/off icons to legend
  handle row.power.power being NULL
  netdisco-docker triage
  typo
  if user installs Pg they should use supported version
  netdisco#610 better MAC addr input sanity checking
  a few more files to ignore (netdisco#609)
  fix pod
  fix pod as in b58a62
  fix pod as in b58a62
  fix pod formatting and typos
  fix pod formatting
  fix pod
  fix pod formatting
  fix pod formatting
  Properly escape angle brackets in C<>
  Fix device_auth formatting in POD
  yaml whitespace matters
  allow stats to run smoothly on ancient Pg 8.4
  release 2.042010
  netdisco#601 fix job queue no longer shows running or queued jobs
  Revert "fix netdisco#601"
  Revert "fix everything that does not use sidebar in web if"
  fix everything that does not use sidebar in web if
  fix netdisco#601
  release 2.042009
  netdisco#581 skip storing and displaying fabricated vlan 0
  perl 5.30 is released
  last pieces of b59043d / netdisco#590 (netdisco#600)
  netdisco#571 tests should not use user local config
  netdisco#589 only show link with highest agg speed if map links between two devices are asymmetric
  netdisco#586 do not show poller performance rows for still running jobs
  netdisco#584 fix for case where port has no corresponding properties row
  netdisco#577 fix bug related to hostnames comprised a-f only
  netdisco#585 make toastr notifications less annoying
  netdisco#590 remove DBIx::Class::Schema::Loader remnants
  netdisco#594 add PK to device_port_log and other tidying
  netdisco#596 fix default value on actionset field
  dbic sync between actual db & our functions/docs (netdisco#595)
  device_auth
  device_auth
  device_auth usage
  device_auth config
  change to device_auth config
  ask for some device info
  html template fixups (netdisco#576)
  configuration has moved to the wiki (netdisco#574)
  allow setting some speudo device  info (netdisco#572)
  intellij support (netdisco#573)
  move testing targets to perl 5.10 and 5.28
  show some opensuse love
  release 2.042008
  minor amendments to previous commit
  improve check_acl performance for basic IP string compare
  release 2.042007
  netdisco#568 use different icon for WAPs from clients
  improve check_acl performance for basic IP string compare
  netdisco#565 fix netdisco-do when no device param needed
  spelling/wording
  wording
  Allow to pass multiple time the -d parameter to perform the discovery of many devices in one command call. (netdisco#564)
  release 2.042006
  do not show ignored dupe jobs in job queue
  fix inconsistency in titlebar global search when port is selected
  netdisco#549 redux - fix for changing pseudo device ports
  netdisco rancid updates (netdisco#558)
  release 2.042005
  fix strange interaction between CORE::sort and List::MoreUtils::uniq
  refactor to try device port vlan update again
  better var names and change logic to skip port
  better sql update, fixed worker return, better logic on vlans
  netdisco#528 record egress untagged vlans in device_port_vlan table
  netdisco#549 clean manual topology after device ports change
  netdisco#551 better error message for both device_auth and snmp_auth
  netdisco#552 device addresses report has broken column data
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ollyg @inphobia