Merge remote-tracking branch 'upstream/master'

* upstream/master: (178 commits) fix for netdisco#633 fix for netdisco#633 fix for netdisco#633 add relation to get latest node on port netdisco#624 device layers search should be OR (not AND) show how to package own radius dictionary files netdisco#630 display full oui vendor improvements to radius patch Modified to add Radius support (netdisco#621) typo typos typo typo typo typo typo typo typos typo typo Change Port Free icon to be more accessible (netdisco#633) you really need to install the packages we ask fix travis make sidebar tiny bit wider (netdisco#625) compare ieee mac against 6 iterations (netdisco#611) add poe on/off icons to legend handle row.power.power being NULL netdisco-docker triage typo if user installs Pg they should use supported version netdisco#610 better MAC addr input sanity checking a few more files to ignore (netdisco#609) fix pod fix pod as in b58a62 fix pod as in b58a62 fix pod formatting and typos fix pod formatting fix pod fix pod formatting fix pod formatting Properly escape angle brackets in C<> Fix device_auth formatting in POD yaml whitespace matters allow stats to run smoothly on ancient Pg 8.4 release 2.042010 netdisco#601 fix job queue no longer shows running or queued jobs Revert "fix netdisco#601" Revert "fix everything that does not use sidebar in web if" fix everything that does not use sidebar in web if fix netdisco#601 release 2.042009 netdisco#581 skip storing and displaying fabricated vlan 0 perl 5.30 is released last pieces of b59043d / netdisco#590 (netdisco#600) netdisco#571 tests should not use user local config netdisco#589 only show link with highest agg speed if map links between two devices are asymmetric netdisco#586 do not show poller performance rows for still running jobs netdisco#584 fix for case where port has no corresponding properties row netdisco#577 fix bug related to hostnames comprised a-f only netdisco#585 make toastr notifications less annoying netdisco#590 remove DBIx::Class::Schema::Loader remnants netdisco#594 add PK to device_port_log and other tidying netdisco#596 fix default value on actionset field dbic sync between actual db & our functions/docs (netdisco#595) device_auth device_auth device_auth usage device_auth config change to device_auth config ask for some device info html template fixups (netdisco#576) configuration has moved to the wiki (netdisco#574) allow setting some speudo device info (netdisco#572) intellij support (netdisco#573) move testing targets to perl 5.10 and 5.28 show some opensuse love release 2.042008 minor amendments to previous commit improve check_acl performance for basic IP string compare release 2.042007 netdisco#568 use different icon for WAPs from clients improve check_acl performance for basic IP string compare netdisco#565 fix netdisco-do when no device param needed spelling/wording wording Allow to pass multiple time the -d parameter to perform the discovery of many devices in one command call. (netdisco#564) release 2.042006 do not show ignored dupe jobs in job queue fix inconsistency in titlebar global search when port is selected netdisco#549 redux - fix for changing pseudo device ports netdisco rancid updates (netdisco#558) release 2.042005 fix strange interaction between CORE::sort and List::MoreUtils::uniq refactor to try device port vlan update again better var names and change logic to skip port better sql update, fixed worker return, better logic on vlans netdisco#528 record egress untagged vlans in device_port_vlan table netdisco#549 clean manual topology after device ports change netdisco#551 better error message for both device_auth and snmp_auth netdisco#552 device addresses report has broken column data ...
rc9000 · Aug 20, 2019 · a090094 · a090094
2 parents be6e178 + 4c1d5d6
commit a090094
Show file tree

Hide file tree

Showing 183 changed files with 2,300 additions and 929 deletions.
diff --git a/.github/issue_template.md b/.github/issue_template.md
@@ -1,12 +1,23 @@
-<!--- Provide a general summary of the issue in the Title above -->
+<!---
+Provide a general summary of the issue in the Title above
 
-<!-- stop! If your ticket is about a device not being detected correctly, -->
-<!-- see SNMP::Info: https://github.com/netdisco/snmp-info/issues/new -->
+STOP! If your ticket is about a device not being detected correctly,
+see SNMP::Info: https://github.com/netdisco/snmp-info/issues/new
 
-<!-- stop! If you have new MIBs to submit, -->
-<!-- see netdisco-mibs: https://github.com/netdisco/netdisco-mibs/issues/new -->
+STOP! If you have new MIBs to submit,
+see netdisco-mibs: https://github.com/netdisco/netdisco-mibs/issues/new
+
+STOP! If you are running a netdisco docker setup,
+see netdisco-docker: https://github.com/netdisco/netdisco-docker/issues/new
+
+everything else about Netdisco's behaviour is good, here :-D
+
+when including netdisco config snippets, whitespace matters since it's a yaml file
+for github issues it really helps if you include the relevant config parts in a codeblock (code fencing)
+see the "code" subject on https://guides.github.com/features/mastering-markdown/ for that)
+this should preserve spaces in the issue tracker and make troubleshooting quicker
+-->
 
-<!-- everything else about Netdisco's behaviour is good, here :-D -->
 
 ## Expected Behavior
 <!--- If you're describing a bug, tell us what should happen -->
@@ -36,3 +47,11 @@
 <!--- Include as many relevant details about the environment you experienced the bug in -->
 * Netdisco version used: 
 * SNMP::Info version used: 
+
+## Device information
+<!--- if the issue relates to specific devices their info would be usefull -->
+<!--- do note that the following command might contain sensitive info, you can -->
+<!--- remove this but let us know if you did so -->
+<!--- change 1.1.1.1 in the below example with the problematic device's ip -->
+
+`netdisco-do show -d 1.1.1.1 -e specify -DI`
diff --git a/.gitignore b/.gitignore
@@ -14,3 +14,8 @@ Build
 _build
 blib
 !.docker/hooks/*
+.idea
+node_modules/*
+yarn.lock
+package.json
+.stylelintrc
diff --git a/.travis.yml b/.travis.yml
@@ -1,29 +1,36 @@
 language: perl
+perl:
+  - "5.30"
+  - "5.10"
+os: linux
+dist: trusty
 addons:
   apt:
     packages:
       - libsnmp-dev
       - phantomjs
+      - graphviz 
   hosts:
     - localhost
 branches:
   only:
     - /^2\.\d{6}$/
     - 'master'
-install: true
+install:
+  - cpanm --quiet --notest PkgConfig Test::CChecker Alien::zlib::Static Alien::OpenSSL::Static Alien::SNMP
 script: |
   perl Build.PL && \
   ./Build && \
   PERL_MM_USE_DEFAULT=1 ./Build installdeps --cpan_client 'cpanm --quiet --notest' && \
   ND_PHANTOMJS=/usr/bin/phantomjs ./Build test --test_files xt/
 notifications:
   irc:
-    on_success: always
-    on_failure: always
+    on_success: change
+    on_failure: change
     channels:
       - 'chat.freenode.net#netdisco'
-  email:
-    on_success: always
-    on_failure: always
-    recipients:
-      - 'netdisco-ng-commit@lists.sourceforge.net'
+#  email:
+#    on_success: always
+#    on_failure: always
+#    recipients:
+#      - 'netdisco-ng-commit@lists.sourceforge.net'
diff --git a/Build.PL b/Build.PL
@@ -26,6 +26,7 @@ Module::Build->new(
     'App::cpanminus' => '1.6108',
     'App::local::lib::helper' => '0.07',
     'Archive::Extract' => '0',
+    'Authen::Radius' => '0',
     'CGI::Expand' => '2.05',
     'Data::Printer' => '0',
     'DBD::Pg' => '0',
@@ -36,7 +37,9 @@ Module::Build->new(
     'Dancer::Plugin::DBIC' => '0.2001',
     'Dancer::Plugin::Auth::Extensible' => '0.30',
     'Dancer::Plugin::Passphrase' => '2.0.1',
+    'Dancer::Plugin::Swagger' => '0',
     'Dancer::Session::Cookie' => '0.27',
+    'Expect' => '0',
     'File::ShareDir' => '1.03',
     'File::Slurper' => '0.009',
     'Guard' => '1.022',
@@ -46,14 +49,15 @@ Module::Build->new(
     'JSON' => '2.90',
     'JSON::XS' => '3.01',
     'List::Util' => '1.49',
-    'List::MoreUtils' => '0.33',
+    'List::MoreUtils' => '0.428',
     'MIME::Base64' => '3.13',
     'Module::Load' => '0.32',
     'Moo' => '1.001000',
     'MCE' => '1.703',
     'Net::Domain' => '1.23',
     'Net::DNS' => '0.72',
     'Net::LDAP' => '0',
+    'Net::OpenSSH' => '0',
     'NetAddr::MAC' => '0.93',
     'NetAddr::IP' => '4.068',
     'Opcode' => '1.07',
@@ -65,14 +69,15 @@ Module::Build->new(
     'Plack::Middleware::Expires' => '0.03',
     'Plack::Middleware::ReverseProxy' => '0.15',
     'Pod::Usage' => 0,
+    'Regexp::Common' => 2017060201,
     'Role::Tiny' => '1.002005',
     'Scope::Guard' => 0,
     'Sereal' => '0',
     'Socket6' => '0.23',
     'Starman' => '0.4008',
     'Storable' => '0',
     'Sys::SigAction' => '0',
-    'SNMP::Info' => '3.64',
+    'SNMP::Info' => '3.68',
     'SQL::Abstract' => '1.85',
     'SQL::Translator' => '0.11024',
     'Template' => '2.24',
@@ -90,12 +95,11 @@ Module::Build->new(
   recommends => {
     'Graph' => '0',
     'GraphViz' => '0',
-    'Net::OpenSSH' => '0',
-    'Expect' => '0',
   },
   test_requires => {
     'Test::More' => '1.302083',
     'Env::Path'  => '0',
+    'Test::Compile' => '0',
     'Test::File::ShareDir::Dist' => '0',
   },
   script_files => [

diff --git a/Changes b/Changes
@@ -1,26 +1,205 @@
-2.040003 - xxx
+2.042010 - 2019-06-02
+
+  [BUG FIXES]
+
+  * #601 fix job queue no longer shows running or queued jobs
+
+2.042009 - 2019-05-30
+
+  [ENHANCEMENTS]
+
+  * #572 allow setting some pseudo device info such as location, contact
+  * #573 support for build within intellij IDE
+  * #585 change default for check_userlog to be false (fewer popup notifications)
+  * #586 do not show poller performance rows for still running jobs
+  * #590, #600 remove DBIx::Class::Schema::Loader remnants
+  * improve documentation for OpenSuSE installation
+  * enable tests on Perl 5.30
+
+  [BUG FIXES]
+
+  * #571 tests should not use user local config
+  * #576 HTML template fixups
+  * #577 fix bug related to hostnames comprised a-f only
+  * #581 skip storing and displaying fabricated vlan 0
+  * #584 fix for case where port has no corresponding properties row
+  * #589 only show link with highest agg speed if map links between two devices are asymmetric
+  * #594, #595, #596 fixes to DB schema PKs and defaults, and documentation
+
+2.042008 - 2019-04-30
+
+  [ENHANCEMENTS]
+
+  * improve check_acl performance for basic IP string compare
+
+2.042007 - 2019-04-28
+
+  [ENHANCEMENTS]
+
+  * #564 allow passing multiple -d (devices) to netdisco-do
+  * #568 use different icon for WAPs from clients
+  * improve check_acl performance for basic IP string compare
+
+2.042006 - 2019-04-16
+
+  [ENHANCEMENTS]
+
+  * #558 netdisco-rancid-export is now a no-op (inphobia)
+  * hide the ignored duplicate jobs in the web job queue display
+
+  [BUG FIXES]
+
+  * #549 redux - fix for changing pseudo device ports
+  * fix inconsistency in titlebar global search when port is selected
+
+2.042005 - 2019-04-03
+
+  [ENHANCEMENTS]
+
+  * #528 record egress untagged vlans in device_port_vlan table
+
+  [BUG FIXES]
+
+  * clickability of port log/control icons in port list display (pyro3d)
+  * #549 clean manual topology after device ports change
+  * #551 better error message for both device_auth and snmp_auth
+  * #552 device addresses report has broken column data
+
+2.042004 - 2019-03-28
+
+  [ENHANCEMENTS]
+
+  * #548 add IS-IS neighbor discovery support (pyro3d)
+
+2.042003 - 2019-03-21
+
+  [BUG FIXES]
+
+  * minor enhancement to the way device_auth falls back to snmp_auth
+
+2.042002 - 2019-03-20
+
+  [ENHANCEMENTS]
+
+  * allow pseudo devices to arpnip
+
+  [BUG FIXES]
+
+  * the store worker phase will return more accurate status
+
+2.042001 - 2019-03-18
+
+  [BUG FIXES]
+
+  * Do not clobber sshcollector config
+
+2.042000 - 2019-03-17
+
+  [NEW FEATURES]
+
+  * Implementation of API authentication and Swagger-UI (pyro3d and ollyg)
+
+2.041002 - 2019-03-17
+
+  [BUG FIXES]
+
+  * fix precedence of device_auth over snmp_auth loading
+  * check legacy config name for nbtstat_response_timeout
+
+2.041001 - 2019-03-15
+
+  [ENHANCEMENTS]
+
+  * add "store" and "late" phases to backend workers
+  * documentation updates
+
+  [BUG FIXES]
+
+  * #539 fix an issue with VLAN reindixing for VRFs (earendilfr)
+  * fix device port change check
+
+2.041000 - 2019-03-12
+
+  [NEW FEATURES]
+
+  * netdisco-sshcollector no longer required - the functionality (arpnip via
+    ssh) will be run within netdisco's core schedule (rc9000 and ollyg)
+
+  * get_credentials replaces get_community and accepts any device_auth stanza
+    in JSON format (ollyg)
+
+2.040007 - 2019-03-06
+
+  [BUG FIXES]
+
+  * #521-redux Search Node Date Range not working (ollyg)
+
+2.040006 - 2019-03-04
+
+  [BUG FIXES]
+
+  * #527 update List::MoreUtils version requirement
+
+2.040005 - 2019-03-04
+
+  [BUG FIXES]
+
+  * #526 fix discover syntax bug
+
+2.040004 - 2019-03-03
+
+  [NEW FEATURES]
+
+  * #510 store ifindex in Device Port Properties table (rc9000)
+  * new discover_waps and discover_phones boolean settings (ollyg)
+
+  [ENHANCEMENTS]
+
+  * #428 Port-Channels now showing in netmap (ollyg)
+  * #490 use new LLDP capability checks for ports having phones (ollyg)
+  * #494 update Cisco ASA ssh collector (stromsoe)
+
+  [BUG FIXES]
+
+  * #492 Port Control incorrectly uses VLAN config check (inphobia)
+  * #493 HTML tag fix (inphobia)
+  * #498 Map with VLAN filter omits unconnected devices (ollyg)
+  * #499 netdisco-do renumber reports wrong ip (inphobia)
+  * #500 no more duplicate entries in vlan filter (ollyg)
+  * #505 renumbering device missed a few tables (ollyg)
+  * #512 fix regression in phone/wap discovery exclusion (ollyg)
+  * #514 ipinventory report returns consistent data (inphobia)
+  * #520 make sure aggports have a master<->slave (ollyg)
+  * #521 Search Node Date Range not working (ollyg)
+  * #522 TypeAhead.pm can reference empty data (inphobia)
+  * fix bug showing no nodes when only one matches in netmap (ollyg)
+
+2.040003 - 2019-01-18
 
   [NEW FEATURES]
 
-  * #482 operating system is now a link in device details (inphobia)
+  * #485 new "VLANs" device tab showing a VLAN report (inphobia)
 
   [ENHANCEMENTS]
 
-  * #408, #417 & 477 makerancidconf improvements: readded with some additional tweaks, somehow
-    they got lost in 2.039029. (earendilfr, inphobia)
-  * #436 make neighbor matching less strict, no longer is it required to match all parameters
-    (port name, device name) exactly before creating a link between devices. (linwood-f)
+  * #408, #417 & 477 makerancidconf improvements re-added (earendilfr, inphobia)
+  * #420 IP Inventory Node column renamed to IP Address (ollyg)
+  * #420 sidebar defaults for IP Inventory report can be overridden (ollyg)
+  * #424 column name is "Connected Nodes & Devices" when both are shown (ollyg)
+  * #436 make neighbor matching less strict in netmap (linwood-f)
+  * #482 operating system is now a link in device details (inphobia)
+  * #486 allow snmp::info base class in netdisco-do (inphobia)
 
   [BUG FIXES]
 
-  * #475 all discover plugins should now respect ignore_interfaces, ignore_notpresent_types &
-    ignore_private_nets. as a bonus discovery data is now cached for less db load. (ollyg)
-  * #476 also log when plugins delete related tables. (ollyg)
-  * #471-redux ospf discovery will now keep on working instead of stopping after a few
-    runs. (ollyg)
-  * #474 better explain public key auth with netdisco-sshcollector. (inphobia)
-  * #457 make sorting work on interface in device/adresses when interface was undefined. also
-    went through all other portsort callers to make sure parameters are always defined. (inphobia)
+  * #457 make sorting work for adresses when interface was undefined (inphobia)
+  * #471-redux ospf discovery will now keep on working (ollyg)
+  * #474 better explain public key auth with netdisco-sshcollector (inphobia)
+  * #475, #479 all discover plugins should now respect ignore_* for interfaces (ollyg)
+  * #476 debug log when deleting rows from related tables (ollyg)
+  * Fix to catch when txrate on wifi is scalar and not a list
+  * Remove 'use vars' which is deprecated in Perl
+  * Various documentation improvements (inphobia)
 
 2.040002 - 2018-12-30