Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: make domain_suffix array #591

Closed
inphobia opened this issue May 23, 2019 · 1 comment
Closed

feature request: make domain_suffix array #591

inphobia opened this issue May 23, 2019 · 1 comment
Assignees
@ollyg
Labels
wishlist

Comments

@inphobia
Copy link
Member

due to politics/management/whatever(/even actual technical reasons) we have multiple dns namespaces in our network. as such our hostnames sometimes contain part of the fqdn. it would be nice if domain_suffix accepted an array or regex or whatever so we can strip more unneeded info.

Possible Solution

make domain_suffix take arrays or regex config.

possible issue: hostnames (not fqdn) might now be duplicate, on the other hand dns allows multiple a records per name & multiple ptr records per reverse (not sure about the multiple ptr records per reverse, but most major resolvers just support it)

Steps to Reproduce (for bugs)

  1. simplest way: create 2 subdomains, for example doma.example.com & domb.example.com
  2. have nodes in both subdomains: host1.doma.example.com & host2.domb.example.com
  3. set domain suffix to .example.com, now nodes will show up in the web interface as host1.doma & host2.domb

Context

Your Environment

  • Netdisco version used: master
  • SNMP::Info version used: master
@ollyg ollyg self-assigned this Jun 30, 2019
ollyg added a commit that referenced this issue Sep 3, 2019
@ollyg
#591 domain_suffix can be list and supports (simple) regexp
542837d 
Squashed commit of the following:

commit 975e4c6
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue Sep 3 13:35:26 2019 +0100

    also support regexp in domain_suffix

commit 0a2b5c8
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue Sep 3 13:17:17 2019 +0100

    fix rancid, graph, and nodemonitor

commit 6d881de
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue Sep 3 13:11:54 2019 +0100

    improve docs and set default domain_suffix to be list

commit 1dcafc0
Merge: 9a752e0 14ac69d
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue Sep 3 13:00:39 2019 +0100

    Merge branch 'master' into og-multiple-domain-suffix

commit 9a752e0
Merge: c836619 82a99ea
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Tue Sep 3 09:45:25 2019 +0100

    Merge branch 'master' into og-multiple-domain-suffix

commit c836619
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Thu Jun 13 07:52:45 2019 +0100

    hokey fix for nodes with domains

commit fed14bd
Author: Oliver Gorwits <oliver@cpan.org>
Date:   Thu Jun 13 07:02:09 2019 +0100

    basic implementation, rancid graph and nodemonitor missing
@ollyg
Copy link
Member

ollyg commented Sep 3, 2019

implemented in:
[master 542837d] #591 domain_suffix can be list and supports (simple) regexp

@ollyg ollyg closed this as completed Sep 3, 2019
inphobia added a commit to netdisco/netdisco-docker that referenced this issue Nov 6, 2019
@inphobia
domain suffix now a list
35ae1bd 
netdisco/netdisco#591
@inphobia inphobia mentioned this issue Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollyg ollyg

Labels
wishlist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ollyg @inphobia