Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aplicando return nullable type #9

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Aplicando return nullable type #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b265d31
Aplicando return nullable type
jakjr Oct 14, 2020
d9c830c
Aplicando return nullable type
jakjr Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Canducci/ZipCode/Contracts/ZipCodeContract.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ interface ZipCodeContract
* @return Canducci\ZipCode\ZipCodeInfo
* @throws Canducci\ZipCode\ZipCodeException
*/
public function find(string $value, bool $renew = false): ZipCodeInfo;
public function find(string $value, bool $renew = false): ?ZipCodeInfo;
}
4 changes: 2 additions & 2 deletions src/Canducci/ZipCode/ZipCode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function __construct(SimpleCacheFilesystem $cache, ZipCodeRequestContract
* @return Canducci\ZipCode\ZipCodeInfo|ZipCodeInfo|null
* @throws ZipCodeException
*/
public function find(string $value, bool $renew = false): ZipCodeInfo
public function find(string $value, bool $renew = false): ?ZipCodeInfo
{
$message = '';
if (is_string($value)) {
Expand Down Expand Up @@ -88,7 +88,7 @@ public function find(string $value, bool $renew = false): ZipCodeInfo
/**
* @return null|string
*/
private function getZipCodeInfo(): string
private function getZipCodeInfo(): ?string
{
$this->renew();
if ($this->cache->has('zipcode_' . $this->value)) {
Expand Down