tests/helpers: Increase timeout and deal with newlines #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TelnetControl can produce multiple newlines, make sure we filter through those. While testing with a Broadcom BCM5301x it was also found that a 10s timeout was too short, bump it up to 20s.
|
The line splitting should probably be moved to Telnet control. I am seeing some weird problems with ser2net that need investigating. The timeout increase is good though. |
|
Okay. Could you split that into two commits so I can integrate the timeout change? About newlines, you made me realize it's a bit inconsistent at the moment. For |
|
Agreed, we should really solve this now so we have a consistent experience with all controls. TelnetControl still seems to suffer from some issues... |
d-k-c
force-pushed
the
master
branch
2 times, most recently
from
ac6b5fe
to
fed2b04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TelnetControl can produce multiple newlines, make sure we filter through
those. While testing with a Broadcom BCM5301x it was also found that a
10s timeout was too short, bump it up to 20s.