Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Symfony 6 and support multiple failure transports #185

Merged
merged 5 commits into from
Apr 5, 2023

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Apr 5, 2023

Introduces service locators for failure receivers (Transports that receive failed messages) and failure senders (Transports that are configured to send failed messages to a failure queue)

Closes #144
Closes #177

Introduces service locators for failure receivers (Transports that receive failed messages) and failure senders (Transports that are configured to send failed messages to a failure queue)
@gsteel gsteel added enhancement New feature or request dependencies Pull requests that update a dependency file BC Break labels Apr 5, 2023
@gsteel gsteel added this to the 2.0.0 milestone Apr 5, 2023
@gsteel gsteel self-assigned this Apr 5, 2023
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 92.75% and project coverage change: -0.62 ⚠️

Comparison is base (ed08bcc) 92.40% compared to head (65e81e0) 91.78%.

❗ Current head 65e81e0 differs from pull request most recent head 360de78. Consider uploading reports for the commit 360de78 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##              2.0.x     #185      +/-   ##
============================================
- Coverage     92.40%   91.78%   -0.62%     
- Complexity      134      158      +24     
============================================
  Files            27       28       +1     
  Lines           500      584      +84     
============================================
+ Hits            462      536      +74     
- Misses           38       48      +10     
Impacted Files Coverage Δ
...lerLocator/OneToOneFqcnContainerHandlerLocator.php 92.00% <ø> (ø)
src/Container/Util.php 80.76% <76.19%> (-19.24%) ⬇️
src/ConfigProvider.php 100.00% <100.00%> (ø)
src/Container/Command/ConsumeCommandFactory.php 96.00% <100.00%> (-0.16%) ⬇️
...iner/Command/FailedMessagesRetryCommandFactory.php 90.90% <100.00%> (ø)
...ontainer/Command/FailureCommandAbstractFactory.php 100.00% <100.00%> (ø)
src/Container/FailureReceiversProvider.php 100.00% <100.00%> (ø)
src/Container/FailureReceiversProviderFactory.php 100.00% <100.00%> (ø)
src/Container/FailureSendersProvider.php 100.00% <100.00%> (ø)
src/Container/FailureSendersProviderFactory.php 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gsteel gsteel merged commit 5a226d4 into 2.0.x Apr 5, 2023
@gsteel gsteel deleted the allow-symfony-6 branch April 5, 2023 13:30
@gsteel gsteel mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Symfony Components to ^6
1 participant