Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exception message for invalid image view names #185

Merged
merged 1 commit into from
Jul 2, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jul 2, 2022

Fixes #182

@gsteel gsteel added the bug Something isn't working label Jul 2, 2022
@gsteel gsteel added this to the 1.2.5 milestone Jul 2, 2022
@gsteel gsteel self-assigned this Jul 2, 2022
@codecov
Copy link

codecov bot commented Jul 2, 2022

Codecov Report

Merging #185 (4b57af0) into 1.2.x (1fae8ac) will increase coverage by 1.67%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##              1.2.x     #185      +/-   ##
============================================
+ Coverage     92.59%   94.26%   +1.67%     
  Complexity      666      666              
============================================
  Files            51       51              
  Lines          1714     1779      +65     
============================================
+ Hits           1587     1677      +90     
+ Misses          127      102      -25     
Impacted Files Coverage Δ
src/Exception/ImageViewNotFound.php 100.00% <100.00%> (ø)
src/Predicate.php 100.00% <0.00%> (ø)
src/Api.php 96.36% <0.00%> (+15.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5443a84...4b57af0. Read the comment docs.

@gsteel gsteel merged commit 3cc3521 into 1.2.x Jul 2, 2022
@gsteel gsteel deleted the 182-fix-exception-message branch July 2, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ugly Exception Message…
1 participant