This repository has been archived by the owner on Jun 27, 2020. It is now read-only.
Add support for django 1.11 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
suggested changes
Apr 27, 2017
| @@ -31,5 +32,5 @@ def test_detail_uuid_exception(self): | |||
| """ | |||
| see https://github.com/interop-dev/django-netjsongraph/issues/4 | |||
| """ | |||
| response = self.client.get('/topology/a083b494-8e16-4054-9537-fb9eba914861-wrong/') | |||
| response = get_topology_or_404('/topology/a083b494-8e16-4054-9537-fb9eba914861-wrong/') | |||
There was a problem hiding this comment.
you shall not change this line
There was a problem hiding this comment.
I see. Does self.client.get automatically call get_topology_or_404?
There was a problem hiding this comment.
self.client.get simulates an HTTP request to the view, see the django docs regarding the test client
django_netjsongraph/utils.py
Outdated
| @@ -61,5 +62,5 @@ def get_topology_or_404(pk, **kwargs): | |||
| }) | |||
| try: | |||
| return get_object_or_404(Topology, **kwargs) | |||
| except ValueError: | |||
| except (ValidationError, ValueError) as e: | |||
There was a problem hiding this comment.
don't add as e, is not needed here
There was a problem hiding this comment.
Yes. Will remove
rohithasrk
force-pushed
the
django-1.11-support
branch
from
11b937f
to
c258d7a
Compare
nemesifier
approved these changes
Apr 27, 2017
rohithasrk
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.