Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Address mobile responsive issues #24

Merged
merged 2 commits into from
Mar 2, 2022
Merged

chore: Address mobile responsive issues #24

merged 2 commits into from
Mar 2, 2022

Conversation

maxcell
Copy link
Contributor

@maxcell maxcell commented Mar 2, 2022

Summary

This is to resolve #23. There was an issue with the description text and some overflow result.

Platform Before After
Mobile Chrome Description text cut off and margin top too low Fixed max width for description text and reduced padding
Mobile Safari Description text cut off and margin top too low Fixed max width for description text and reduced padding

@maxcell maxcell requested a review from tzmanics March 2, 2022 17:57
@maxcell maxcell self-assigned this Mar 2, 2022
tzmanics
tzmanics approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@tzmanics tzmanics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Looks great!

@maxcell maxcell merged commit 7492b14 into main Mar 2, 2022
@maxcell maxcell deleted the pw/23/mobile-styles branch March 2, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzmanics tzmanics tzmanics approved these changes

Assignees

@maxcell maxcell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix mobile layout
2 participants
@maxcell @tzmanics