fix: repository root directory validation #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
commented
Sep 8, 2021
| // However we allow file paths to be outside of the build directory, since this | ||
| // can be convenient in monorepo setups. | ||
| const validateInsideRoot = function (originalPath, path, repositoryRoot, propName) { | ||
| if (relative(repositoryRoot, path).startsWith('..') || getWindowsDrive(repositoryRoot) !== getWindowsDrive(path)) { |
There was a problem hiding this comment.
path.relative() returns C:\\... instead of ..\... on Windows when the file paths are on different drives.
ehmicky
commented
Sep 8, 2021
| ␊ | ||
| [functions]␊ | ||
| directory = "functions_dir"` | ||
| Configuration property "functionsDirectory" "/external/path" must be inside the repository root directory.` |
There was a problem hiding this comment.
The validation message changed.
ehmicky
commented
Sep 8, 2021
| @@ -1134,32 +1213,6 @@ Generated by [AVA](https://avajs.dev). | |||
| "directory-two/**/*.jpg"␊ | |||
| ]` | |||
|
|
|||
| ## functions.included_files: does not contain paths outside of the root directory | |||
There was a problem hiding this comment.
This specific property is checked and handled by zip-it-and-ship-it instead.
JGAntunes
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3431
Fixes netlify/zip-it-and-ship-it#609
This allows configuration file paths to target files outside of the
basedirectory, providing they are inside the repository root directory.