Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate edge_functions in config #4291

Merged
merged 6 commits into from
May 19, 2022

Conversation

jackiewmacharia
Copy link
Contributor

Summary

Fixes https://github.com/netlify/pillar-runtime/issues/238


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)
gary-bendig-6GMq7AGxNbE-unsplash

Photo by Gary Bendig on Unsplash

@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label May 16, 2022
@jackiewmacharia jackiewmacharia requested a review from a team May 16, 2022 08:27
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we'll also want to validate the objects inside edge_functions. Also, we'll need some tests.

@eduardoboucas
Copy link
Member

Also, we shouldn't be using the chore: prefix for changes in runtime functionality. This should be a feat: or a fix:, otherwise release-please won't generate a release from it.

@jackiewmacharia jackiewmacharia changed the title chore: validate edge_functions in config feat: validate edge_functions in config May 18, 2022
@jackiewmacharia jackiewmacharia added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 18, 2022
@jackiewmacharia jackiewmacharia changed the title feat: validate edge_functions in config fix: validate edge_functions in config May 18, 2022
@jackiewmacharia jackiewmacharia added type: bug code to address defects in shipped code and removed type: chore work needed to keep the product and development running smoothly type: feature code contributing to the implementation of a feature and/or user facing functionality labels May 18, 2022
@jackiewmacharia
Copy link
Contributor Author

@eduardoboucas this one is now ready.

Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! πŸŽ‰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants