-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate edge_functions in config #4291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think we'll also want to validate the objects inside edge_functions
. Also, we'll need some tests.
Also, we shouldn't be using the |
@eduardoboucas this one is now ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! π
Summary
Fixes https://github.com/netlify/pillar-runtime/issues/238
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
![gary-bendig-6GMq7AGxNbE-unsplash](https://user-images.githubusercontent.com/16131515/168550366-29e1534a-a946-480e-9ed0-df3568eafb6b.jpeg)
Photo by Gary Bendig on Unsplash