fix: now builds fail if the Next runtime is >= 4.0.0 && < 4.26.0 #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
nickytonline
force-pushed
the
nickytonline/fail-build-if-next-runtime-requires-update
branch
2 times, most recently
from
e259dc0
to
dee6701
Compare
nickytonline
force-pushed
the
nickytonline/fail-build-if-next-runtime-requires-update
branch
from
dee6701
to
2266671
Compare
nickytonline
commented
Nov 3, 2022
| if (outdatedPlugins.length === 0) { | ||
| return | ||
| } | ||
|
|
||
| throwIfOutdatedNextRuntime(outdatedPlugins) |
There was a problem hiding this comment.
Need the feature flag for this.
MarcL
reviewed
Nov 3, 2022
| // maybe there's a semver package to check this | ||
|
|
||
| // version >= 4.0.0 && < 4.26.0 | ||
| return (major === 4 && minor >= 0 && minor < 26) || (minor === 26 && patch === 0) |
There was a problem hiding this comment.
I think there's a @npm/semver package used in this repo so better to use that?
// Think this semver range is correct for >= 4.0.0 but < 4.26.0
semver.satisfies('4.0.0 - 4.26.0')
There was a problem hiding this comment.
Make sure you set includePrerelease to true
MarcL
reviewed
Nov 3, 2022
| * | ||
| * @throws Error Throws an error if the Next runtime is >= 4.0.0 || < 4.26.0 | ||
| */ | ||
| export const logOutdatedPlugins = function (logs, outdatedPlugins) { |
There was a problem hiding this comment.
Name slightly misleading now that it throws too?
orinokai
reviewed
Nov 3, 2022
ascorbic
reviewed
Nov 3, 2022
| * | ||
| * @throws Error | ||
| */ | ||
| const throwIfOutdatedNextRuntime = function (outdatedPlugins) { |
There was a problem hiding this comment.
Even though this is just Next for now, it would be better if this had a generic name
There was a problem hiding this comment.
Sounds good. I was just being explicit as I thought this was a temporary one off.
5 tasks
|
Closed in favour of #4672. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
I haven't tried this out yet and it needs tests.
Fixes #<replace_with_issue_number>
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)