only log if manifest has keys

netlify · May 15, 2019 · 0c6c60f · 0c6c60f
1 parent 29ed42b
commit 0c6c60f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/commands/addons/config.js b/src/commands/addons/config.js
@@ -41,14 +41,15 @@ class AddonsConfigCommand extends Command {
 
     // TODO update getAddonManifest to https://open-api.netlify.com/#/default/showServiceManifest
     const manifest = await getAddonManifest(addonName, accessToken)
+    const hasConfig = manifest.config && Object.keys(manifest.config).length
     // Parse flags
     const rawFlags = parseRawFlags(raw)
     // Get Existing Config
     const currentConfig = currentAddon.config || {}
 
     const words = `Current "${addonName} add-on" Settings:`
     console.log(` ${chalk.yellowBright.bold(words)}`)
-    if (manifest.config) {
+    if (hasConfig) {
       render.configValues(addonName, manifest.config, currentConfig)
     } else {
       // For addons without manifest. TODO remove once we enfore manifests
@@ -57,7 +58,7 @@ class AddonsConfigCommand extends Command {
       })
     }
 
-    if (manifest.config) {
+    if (hasConfig) {
       const required = requiredConfigValues(manifest.config)
       const missingValues = missingConfigValues(required, rawFlags)
 

diff --git a/src/commands/addons/create.js b/src/commands/addons/create.js
@@ -56,9 +56,10 @@ class AddonsCreateCommand extends Command {
     }
 
     const manifest = await getAddonManifest(addonName, accessToken)
+     const hasConfig = manifest.config && Object.keys(manifest.config).length
 
     let configValues = rawFlags
-    if (manifest.config && Object.keys(manifest.config).length) {
+    if (hasConfig) {
       const required = requiredConfigValues(manifest.config)
       const missingValues = missingConfigValues(required, rawFlags)
       console.log(`Starting the setup for "${addonName} add-on"`)