fix: proxy server for Node.js 17/18 (#4835)

* fix: proxy server for Node.js 17/18

* fix(tests): try something

* fix(tests): use hardcoded IP

src/utils/proxy.js

@@ -279,7 +279,7 @@ const initializeProxy = async function ({ configPath, distDir, port, projectDir
   const proxy = httpProxy.createProxyServer({
     selfHandleResponse: true,
     target: {
-      host: 'localhost',
+      host: '127.0.0.1',
       port,
     },
   })
@@ -349,7 +349,7 @@ const initializeProxy = async function ({ configPath, distDir, port, projectDir
     }
 
     const responseData = []
-    const requestURL = new URL(req.url, `http://${req.headers.host || 'localhost'}`)
+    const requestURL = new URL(req.url, `http://${req.headers.host || '127.0.0.1'}`)
     const headersRules = headersForPath(headers, requestURL.pathname)
 
     proxyRes.on('data', function onData(data) {
@@ -392,7 +392,7 @@ const initializeProxy = async function ({ configPath, distDir, port, projectDir
 
   const handlers = {
     web: (req, res, options) => {
-      const requestURL = new URL(req.url, 'http://localhost')
+      const requestURL = new URL(req.url, 'http://127.0.0.1')
       req.proxyOptions = options
       req.alternativePaths = alternativePathsFor(requestURL.pathname).map((filePath) => filePath + requestURL.search)
       // Ref: https://nodejs.org/api/net.html#net_socket_remoteaddress
@@ -428,7 +428,7 @@ const onRequest = async ({ addonsUrls, edgeFunctionsProxy, functionsServer, prox
   const options = {
     match,
     addonsUrls,
-    target: `http://localhost:${settings.frameworkPort}`,
+    target: `http://127.0.0.1:${settings.frameworkPort}`,
     publicFolder: settings.dist,
     functionsServer,
     functionsPort: settings.functionsPort,
@@ -474,7 +474,7 @@ const startProxy = async function ({
   settings,
   state,
 }) {
-  const functionsServer = settings.functionsPort ? `http://localhost:${settings.functionsPort}` : null
+  const functionsServer = settings.functionsPort ? `http://127.0.0.1:${settings.functionsPort}` : null
   const edgeFunctionsProxy = await edgeFunctions.initializeProxy({
     config,
     configPath,

tests/integration/400.command.dev.test.js

@@ -8,8 +8,6 @@ const avaTest = require('ava')
 const { isCI } = require('ci-info')
 const FormData = require('form-data')
 
-const { originalIP } = require('../lib/local-ip')
-
 const { withDevServer } = require('./utils/dev-server')
 const got = require('./utils/got')
 const { withSiteBuilder } = require('./utils/site-builder')
@@ -407,7 +405,7 @@ test('should handle form submission', async (t) => {
         payload: {
           created_at: body.payload.created_at,
           data: {
-            ip: originalIP,
+            ip: '::ffff:127.0.0.1',
             some: 'thing',
             user_agent: 'got (https://github.com/sindresorhus/got)',
           },

tests/integration/500.command.dev.test.js

@@ -7,8 +7,6 @@ const avaTest = require('ava')
 const { isCI } = require('ci-info')
 const FormData = require('form-data')
 
-const { originalIP } = require('../lib/local-ip')
-
 const { withDevServer } = require('./utils/dev-server')
 const got = require('./utils/got')
 const { withSiteBuilder } = require('./utils/site-builder')
@@ -102,7 +100,7 @@ test('should handle form submission', async (t) => {
         payload: {
           created_at: body.payload.created_at,
           data: {
-            ip: originalIP,
+            ip: '::ffff:127.0.0.1',
             some: 'thing',
             user_agent: 'got (https://github.com/sindresorhus/got)',
           },