fix(command-build): allow setting context via CONTEXT env, default to production #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 41494be Package size: 355 MB⬇️ 0.00% decrease vs. 41494be Legend
|
erezrokah
commented
Jan 14, 2022
erezrokah
commented
Jan 14, 2022
| context: | ||
| options.context || | ||
| process.env.CONTEXT || | ||
| (['dev', 'dev:exec', 'dev:trace'].includes(this.name()) ? 'dev' : undefined), |
There was a problem hiding this comment.
This was previously done in an oclif child class, not sure if there's a better way to do it now.
There was a problem hiding this comment.
I don't think either. I would add a small comment here in the code to outline why we are checking for ((['dev', 'dev:exec', 'dev:trace'] to help our future selfs when touching this code again 😂
There was a problem hiding this comment.
Good point, done in 7ba6367
lukasholzer
previously approved these changes
Jan 17, 2022
| context: | ||
| options.context || | ||
| process.env.CONTEXT || | ||
| (['dev', 'dev:exec', 'dev:trace'].includes(this.name()) ? 'dev' : undefined), |
There was a problem hiding this comment.
I don't think either. I would add a small comment here in the code to outline why we are checking for ((['dev', 'dev:exec', 'dev:trace'] to help our future selfs when touching this code again 😂
lukasholzer
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #4039
this.name()is always defined, so it overrides the environment variable (which is evaluated in@netlify/config). Also@netlify/configdefaults toproductioncontext, so we should passundefinedto allow the default behavior.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)