Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev): document how to disable browser auto launch #4106

Merged
merged 3 commits into from Jan 21, 2022

Conversation

albertodeago
Copy link
Contributor

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Fixes #4100

Document how to avoid the browser being auto opened when using netlify dev.

  • Add docs in the command
  • Add docs in the Netlify Dev usage page

Feel free to suggest better text or anything

Screenshots of the modified docs

image

image


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

he ⬇ wrote the docs so if there are errors it's not my fault
image

@albertodeago albertodeago requested a review from a team as a code owner January 21, 2022 16:34
'netlify dev',
'netlify dev -d public',
'netlify dev -c "hugo server -w" --targetPort 1313',
'BROWSER=firefox netlify dev # auto open firefox instead of preferred browser',
Copy link
Contributor

@erezrokah erezrokah Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit should work (setting to firefox), but currently doesn't due to an upstream bug:
michaellzc/better-opn#38

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, the only thing I didn't try.. my bad, I'll change it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, better to remove it for now

@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jan 21, 2022
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes until the removal of BROWSER=firefox

@erezrokah erezrokah added the automerge Add to Kodiak auto merge queue label Jan 21, 2022
@kodiakhq kodiakhq bot merged commit b15f228 into netlify:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to turn off autoLaunch in dev command
2 participants