-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass site information to edge function context in dev command #4857
Merged
khendrikse
merged 8 commits into
main
from
feat/4775/add-site-to-edge-functions-context-in-dev-command
Jul 27, 2022
Merged
feat: pass site information to edge function context in dev command #4857
khendrikse
merged 8 commits into
main
from
feat/4775/add-site-to-edge-functions-context-in-dev-command
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Jul 25, 2022
📊 Benchmark resultsComparing with 91ba4fe Package size: 221 MB(no change)
Legend
|
khendrikse
force-pushed
the
feat/4775/add-site-to-edge-functions-context-in-dev-command
branch
from
July 26, 2022 11:57
cb0e697
to
cb5e64a
Compare
khendrikse
force-pushed
the
feat/4775/add-site-to-edge-functions-context-in-dev-command
branch
from
July 26, 2022 13:05
ac8439e
to
68e223f
Compare
khendrikse
force-pushed
the
feat/4775/add-site-to-edge-functions-context-in-dev-command
branch
from
July 26, 2022 13:20
68e223f
to
0c35208
Compare
eduardoboucas
previously approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! ✨
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
eduardoboucas
previously approved these changes
Jul 26, 2022
@eduardoboucas I renamed the other tests withSiteBuilder as well |
eduardoboucas
previously approved these changes
Jul 26, 2022
danez
reviewed
Jul 26, 2022
eduardoboucas
approved these changes
Jul 27, 2022
khendrikse
deleted the
feat/4775/add-site-to-edge-functions-context-in-dev-command
branch
July 27, 2022 11:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4775
Passing site information to the Edge Functions context object when using the dev command.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)