Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency read-pkg-up to v7 #1176

Merged
merged 3 commits into from
Aug 31, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 31, 2020

This PR contains the following updates:

Package Type Update Change
read-pkg-up dependencies major ^6.0.0 -> ^7.0.0

Release Notes

sindresorhus/read-pkg-up

v7.0.1

Compare Source

v7.0.0

Compare Source

Breaking
  • Rename .package to .packageJson 8140c73
    I'm really sorry about the churn. It was brought to my attention that package is a reserved keyword, and it meant that the result could previously not be easily destructured.

Renovate configuration

馃搮 Schedule: "before 3am on Monday" (UTC).

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Aug 31, 2020
@renovate renovate bot force-pushed the renovate/read-pkg-up-7.x branch from 75995b9 to 2875436 Compare August 31, 2020 11:36
@erezrokah erezrokah requested a review from ehmicky August 31, 2020 12:14
@erezrokah
Copy link
Contributor

erezrokah commented Aug 31, 2020

@ehmicky adding you as a reviewer just in case I'm missing something.
I wanted to update the code that uses read-pkg-up due to the breaking change (the change should be in the result, changing package to packageJson), but saw that we are already referencing the wrong property pkg:

const packageJson = currentModule.pkg

pkg was renamed to package in version 6 and again to packageJson in version 7:
https://github.com/sindresorhus/read-pkg-up/releases/tag/v6.0.0
https://github.com/sindresorhus/read-pkg-up/releases/tag/v7.0.0

Since the current code wasn't supposed to work anyway, I searched the repo and couldn't find a reference to getDependencies so I deleted that function and removed a bunch of dependencies it was using.

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I can't believe how big this chunk of dead code was, with many dependencies!
Thanks @erezrokah for spotting that up! 馃帀

@erezrokah erezrokah merged commit b83885e into master Aug 31, 2020
@erezrokah erezrokah deleted the renovate/read-pkg-up-7.x branch August 31, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants