chore: cleanup site scripts #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
ehmicky
reviewed
Sep 9, 2020
| "build": "run-s build:*", | ||
| "build:site": "cd site && npm install && npm run build", | ||
| "ci": "run-s test build", | ||
| "build:site": "cd site && npm ci && npm run build", |
There was a problem hiding this comment.
Would npm install be better than npm ci when running this locally?
There was a problem hiding this comment.
I would actually always opt for npm ci (so developers always have the same dependencies installed), unless one is explicitly trying to update dependencies.
npm install will update the lock file if it doesn't match with package.json. I prefer to fail in that case.
ehmicky
approved these changes
Sep 9, 2020
erezrokah
force-pushed
the
chore/cleanup_scripts
branch
from
678ce87
to
cac985e
Compare
This was referenced Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #1191
- Test plan
Not relevant
- Description for the changelog
Moved relevant site scripts under
site/scriptsand removed the unused (so it seems)algolia.jsscript- A picture of a cute animal (not mandatory but encouraged)
馃悎