Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(command-dev-trace): re-enable tests #1388

Merged
merged 1 commit into from Oct 14, 2020
Merged

test(command-dev-trace): re-enable tests #1388

merged 1 commit into from Oct 14, 2020

Conversation

erezrokah
Copy link
Contributor

This PR reintroduces netlify dev:trace command tests with some improvements:

  1. Uses the latest version of gh-release-fetch that allows passing fetch options. We use it to pass an auth token that allows for much higher rate limits.
  2. Pre-installs the traffic mesh agent so tests can run in parallel.

@erezrokah erezrokah requested a review from a team as a code owner October 14, 2020 17:50
@erezrokah erezrokah added the type: chore work needed to keep the product and development running smoothly label Oct 14, 2020
@erezrokah erezrokah changed the title test(command-dev): re-enable tests test(command-dev-trace): re-enable tests Oct 14, 2020
@erezrokah erezrokah merged commit 1da8647 into master Oct 14, 2020
@erezrokah erezrokah deleted the test/pass_github_token_to_gh_fetcher branch October 14, 2020 18:21
@ehmicky
Copy link
Contributor

ehmicky commented Oct 14, 2020

Nice! 🎉

@erezrokah erezrokah mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

@ehmicky ehmicky Awaiting requested review from ehmicky

Assignees
No one assigned
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erezrokah @ehmicky @calavera