Upgrade @netlify/eslint-config-node
#1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
This was referenced Oct 28, 2020
erezrokah
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades
@netlify/eslint-config-node.This takes an approach slightly different from the one commented in #1472 (comment), to decrease the amount of PRs and back-and-forth.
Instead,
@netlify/eslint-config-nodenow contains all the rules we might want to enable. In Netlify Build, all those rules currently work. In the CLI, there are a few rules that require additional refactoring, so they are explicitly disabled. We can fix those one at a time. If it turns out a specific rule is to much of a problem, or we want to change rule options, we can do it directly on@netlify/eslint-config-node, then make a new release.