Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log PATH to be cross-platform #208

Merged
merged 1 commit into from Feb 8, 2019
Merged

Fix log PATH to be cross-platform #208

merged 1 commit into from Feb 8, 2019

Conversation

XhmikosR
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 64c175a on XhmikosR:master into 2961ecb on netlify:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 64c175a on XhmikosR:master into 2961ecb on netlify:master.

@XhmikosR
Copy link
Contributor Author

Coveralls should run only for one node.js version BTW.

@bcomnes
Copy link
Contributor

bcomnes commented Feb 1, 2019

Sorry @XhmikosR playing lots of catchup . Thank you for the contribution, I will land soon.

bcomnes
bcomnes approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bcomnes bcomnes merged commit 99763c3 into netlify:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera requested changes

@bcomnes bcomnes bcomnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XhmikosR @coveralls @bcomnes @calavera