Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prune before shrinkwrap #236

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@bcomnes
Copy link
Contributor

commented Jan 31, 2019

After adding a shrinkwrap I discovered npm stupidly installs devDependencies even when the package is installed as a global dependency. When is that ever the desired case?

Either way, this runs a production prune before packing, then undoes it. Slower publish times, but at least we wont publish devDeps.

@bcomnes bcomnes self-assigned this Jan 31, 2019

@bcomnes bcomnes merged commit 4dbde86 into master Jan 31, 2019

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/cli/deploy-preview Deploy preview ready!
Details

@bcomnes bcomnes changed the title Run prune before shrink-wrap Run prune before shrinkwrap Jan 31, 2019

@bcomnes bcomnes deleted the dont-shrinkwrap-dev branch Jan 31, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jan 31, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 761fcc5 on dont-shrinkwrap-dev into a5a5777 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.