Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sites): clone the generated repo #4411 #4427

Merged
merged 12 commits into from Mar 8, 2022
Merged

feat(sites): clone the generated repo #4411 #4427

merged 12 commits into from Mar 8, 2022

Conversation

iib0011
Copy link
Contributor

@iib0011 iib0011 commented Mar 6, 2022

Summary

Fixes #4411
Now the user is asked if he wants to clone the generated repo.

@erezrokah erezrokah added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Mar 7, 2022
erezrokah
erezrokah suggested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iib0011 for picking up this issue so quickly.

I left a few comments for your consideration.

src/commands/sites/sites-create-template.js Outdated Show resolved Hide resolved
@iib0011 iib0011 requested a review from erezrokah March 7, 2022 11:09
erezrokah
erezrokah approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iib0011, I moved the clone after the site details are printed for more context.

Also added a 🚀 emoji for fun 😄 , and changed the default to true.

Thanks again for the speedy contribution.

@erezrokah erezrokah added the automerge Add to Kodiak auto merge queue label Mar 7, 2022
@iib0011
Copy link
Contributor Author

iib0011 commented Mar 8, 2022

Glad to help

@kodiakhq kodiakhq bot merged commit 63c74f5 into netlify:main Mar 8, 2022
@token-generator-app token-generator-app bot mentioned this pull request Mar 8, 2022
Merged
@token-generator-app token-generator-app bot mentioned this pull request May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
automerge Add to Kodiak auto merge queue type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(sites-create-template): clone the generated repo
2 participants
@iib0011 @erezrokah