fix: resolve missing output when using --json #4759
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4758
Adds support for
--json
when using withnetlify deploy --trigger
.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
Just to call out, I had intended to add an integration test in
./tests/integration/210.command.deploy.test.js
along the lines of below. However, because the test site isn't built from/linked to a git codebase, the--trigger
option (which callscreateSiteBuild
) returns a 404 (doesn't have a codebase to build from).I think it would make sense for a Netlify developer to specify the repo this should be linked to (and by extension add tests for
--trigger
. (I'm guessing that is why it hasn't been covered before now)