Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Make functions port configureable #525

Merged
merged 4 commits into from Sep 11, 2019
Merged

Conversation

RaeesBhatti
Copy link
Contributor

@RaeesBhatti RaeesBhatti commented Sep 11, 2019

- Summary
Fixes: #452
Make port for functions server configureable when running via netlify dev.

- Test plan

- Description for the changelog

  • Try to use functionsPort coming from config as port for functions server if defined, otherwise revert to 34567.

- A picture of a cute animal (not mandatory but encouraged)
馃惗

Copy link
Contributor

@jschatz1 jschatz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 鉂わ笍

@RaeesBhatti RaeesBhatti merged commit fb0cc2c into master Sep 11, 2019
@RaeesBhatti RaeesBhatti deleted the raees/functions-port branch September 11, 2019 19:18
@swyxio
Copy link
Contributor

swyxio commented Sep 11, 2019

@RaeesBhatti this should be in dev block not build block.

  port = 8888 # port for dev server
  functionsPort = 34567 # port for functions server

@RaeesBhatti
Copy link
Contributor Author

Oh yes @sw-yx thanks. Fixed here: c7a78f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make netlify dev functionsPort configurable
3 participants