feat: support `context.params` + `config.method` in functions + edge functions #5970

Skn0tt · 2023-08-28T17:07:24Z

Part of https://github.com/netlify/pod-dev-foundations/issues/578.

This PR does a bunch of related things:

Adds support for context.params in local functions to CLI.
Adds support for config.methods in edge functions.
Adds support for config.methods in functions.

I opted for a single PR instead of multiple ones, so we have fewer merge conflicts.

We're still missing methods support for TOML-declared methods. I'll do that in a follow-up, once the @netlify/config change is released.

github-actions · 2023-08-28T17:08:44Z

📊 Benchmark results

Comparing with 8441878

Dependency count: 1,331 (no change)
Package size: 295 MB (no change)

eduardoboucas

LGTM! Let's please add the JSDoc bit, but otherwise it's good to go.

src/lib/edge-functions/registry.mjs

eduardoboucas · 2023-09-05T08:51:52Z

src/lib/functions/netlify-function.mjs

@@ -177,7 +182,7 @@ export default class NetlifyFunction {
      return false
    })

-    return isMatch
+    return match?.pattern


nit: Returning just the pattern feels a bit random and too tied to the way we're currently using this method. I'd say that it feels more natural to return the whole route and then use from it whatever you need. Totally not a big deal, though.

done in 0666c4b

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

eduardoboucas

🚀

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.5.0` -> `6.6.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.5.0/6.6.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.5.0` -> `6.6.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/6.5.0/6.6.0) | | [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.5.0` -> `6.6.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2ftypescript-estree/6.5.0/6.6.0) | | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.48.0` -> `8.49.0`](https://renovatebot.com/diffs/npm/eslint/8.48.0/8.49.0) | | [netlify-cli](https://github.com/netlify/cli) | devDependencies | minor | [`16.2.0` -> `16.3.1`](https://renovatebot.com/diffs/npm/netlify-cli/16.2.0/16.3.1) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v6.6.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#660-2023-09-04) [Compare Source](typescript-eslint/typescript-eslint@v6.5.0...v6.6.0) ##### Bug Fixes - **eslint-plugin:** \[key-spacing] consider properties with parens and comments ([#7525](typescript-eslint/typescript-eslint#7525)) ([7012279](typescript-eslint/typescript-eslint@7012279)) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v6.6.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#660-2023-09-04) [Compare Source](typescript-eslint/typescript-eslint@v6.5.0...v6.6.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/typescript-estree)</summary> ### [`v6.6.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/typescript-estree/CHANGELOG.md#660-2023-09-04) [Compare Source](typescript-eslint/typescript-eslint@v6.5.0...v6.6.0) **Note:** Version bump only for package [@typescript-eslint/typescript-estree](https://github.com/typescript-eslint/typescript-estree) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.49.0`](https://github.com/eslint/eslint/releases/tag/v8.49.0) [Compare Source](eslint/eslint@v8.48.0...v8.49.0) #### Features - [`da09f4e`](eslint/eslint@da09f4e) feat: Implement onUnreachableCodePathStart/End ([#17511](eslint/eslint#17511)) (Nicholas C. Zakas) - [`32b2327`](eslint/eslint@32b2327) feat: Emit deprecation warnings in RuleTester ([#17527](eslint/eslint#17527)) (Nicholas C. Zakas) - [`acb7df3`](eslint/eslint@acb7df3) feat: add new `enforce` option to `lines-between-class-members` ([#17462](eslint/eslint#17462)) (Nitin Kumar) #### Documentation - [`ecfb54f`](eslint/eslint@ecfb54f) docs: Update README (GitHub Actions Bot) - [`de86b3b`](eslint/eslint@de86b3b) docs: update `no-promise-executor-return` examples ([#17529](eslint/eslint#17529)) (Nitin Kumar) - [`032c4b1`](eslint/eslint@032c4b1) docs: add typescript template ([#17500](eslint/eslint#17500)) (James) - [`cd7da5c`](eslint/eslint@cd7da5c) docs: Update README (GitHub Actions Bot) #### Chores - [`b7621c3`](eslint/eslint@b7621c3) chore: remove browser test from `npm test` ([#17550](eslint/eslint#17550)) (Milos Djermanovic) - [`cac45d0`](eslint/eslint@cac45d0) chore: upgrade [@eslint/js](https://github.com/eslint/js)[@8](https://github.com/8).49.0 ([#17549](eslint/eslint#17549)) (Milos Djermanovic) - [`cd39508`](eslint/eslint@cd39508) chore: package.json update for [@eslint/js](https://github.com/eslint/js) release (ESLint Jenkins) - [`203a971`](eslint/eslint@203a971) ci: bump actions/checkout from 3 to 4 ([#17530](eslint/eslint#17530)) (dependabot\[bot]) - [`a40fa50`](eslint/eslint@a40fa50) chore: use eslint-plugin-jsdoc's flat config ([#17516](eslint/eslint#17516)) (Milos Djermanovic) - [`926a286`](eslint/eslint@926a286) test: replace Karma with Webdriver.IO ([#17126](eslint/eslint#17126)) (Christian Bromann) - [`f591d2c`](eslint/eslint@f591d2c) chore: Upgrade config-array ([#17512](eslint/eslint#17512)) (Nicholas C. Zakas) </details> <details> <summary>netlify/cli (netlify-cli)</summary> ### [`v16.3.1`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1631-2023-09-06) [Compare Source](netlify/cli@v16.3.0...v16.3.1) ##### Bug Fixes - **deps:** update dependency [@netlify/build](https://github.com/netlify/build) to v29.20.13 ([#5981](netlify/cli#5981)) ([d9545fa](netlify/cli@d9545fa)) - **deps:** update dependency [@netlify/edge-bundler](https://github.com/netlify/edge-bundler) to v8.19.1 ([#5983](netlify/cli#5983)) ([9d86237](netlify/cli@9d86237)) ### [`v16.3.0`](https://github.com/netlify/cli/blob/HEAD/CHANGELOG.md#1630-2023-09-06) [Compare Source](netlify/cli@v16.2.0...v16.3.0) ##### Features - support `context.params` + `config.method` in functions + edge functions ([#5970](netlify/cli#5970)) ([6afe7bd](netlify/cli@6afe7bd)) ##### Bug Fixes - **deps:** update netlify packages ([#5972](netlify/cli#5972)) ([34e0faa](netlify/cli@34e0faa)) - **deps:** update netlify packages ([#5974](netlify/cli#5974)) ([4a7d9df](netlify/cli@4a7d9df)) - make lm:setup test pass ([#5980](netlify/cli#5980)) ([40b3e78](netlify/cli@40b3e78)) - show proper `req.url` in HTTPS mode ([#5968](netlify/cli#5968)) ([da723a1](netlify/cli@da723a1)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3pm on Sunday" in timezone America/New_York, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: chris b <blue.iron1752@chrisb.xyz> Reviewed-on: https://git.chriswb.dev/chrisw-b/PersonalApi/pulls/6 Co-authored-by: Renovate Bot <renovate.bot@chrisb.xyz> Co-committed-by: Renovate Bot <renovate.bot@chrisb.xyz>

Skn0tt requested a review from a team as a code owner August 28, 2023 17:07

Skn0tt self-assigned this Aug 28, 2023

Skn0tt added 2 commits August 29, 2023 09:27

feat: support context.params in functions

0ef460d

feat: support config.methods in functions

1ce3824

Skn0tt force-pushed the functions-context-param branch from 60e79a0 to 1ce3824 Compare August 29, 2023 07:27

feat: support method matching in edge functions

6aabaab

Skn0tt changed the title ~~feat: support context.params in functions~~ feat: support context.params + config.method in functions + edge functions Aug 29, 2023

eduardoboucas reviewed Sep 5, 2023

View reviewed changes

Skn0tt and others added 4 commits September 5, 2023 11:13

Update src/lib/edge-functions/registry.mjs

30b6ad4

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>

chore: use ts syntax of arrays

692946c

fix: oops, method isn't an array!

8339df4

refactor: return matched route

0666c4b

eduardoboucas approved these changes Sep 5, 2023

View reviewed changes

Merge branch 'main' into functions-context-param

25ad006

Skn0tt merged commit 6afe7bd into main Sep 5, 2023
66 checks passed

Skn0tt deleted the functions-context-param branch September 5, 2023 11:32

token-generator-app bot mentioned this pull request Sep 5, 2023

chore(main): release 16.3.0 #5973

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support `context.params` + `config.method` in functions + edge functions #5970

feat: support `context.params` + `config.method` in functions + edge functions #5970

Skn0tt commented Aug 28, 2023 •

edited

github-actions bot commented Aug 28, 2023 •

edited

eduardoboucas left a comment

eduardoboucas Sep 5, 2023

Skn0tt Sep 5, 2023

eduardoboucas left a comment

feat: support context.params + config.method in functions + edge functions #5970

feat: support context.params + config.method in functions + edge functions #5970

Conversation

Skn0tt commented Aug 28, 2023 • edited

github-actions bot commented Aug 28, 2023 • edited

📊 Benchmark results

eduardoboucas left a comment

Choose a reason for hiding this comment

eduardoboucas Sep 5, 2023

Choose a reason for hiding this comment

Skn0tt Sep 5, 2023

Choose a reason for hiding this comment

eduardoboucas left a comment

Choose a reason for hiding this comment

feat: support `context.params` + `config.method` in functions + edge functions #5970

feat: support `context.params` + `config.method` in functions + edge functions #5970

Skn0tt commented Aug 28, 2023 •

edited

github-actions bot commented Aug 28, 2023 •

edited