fix: clear dist directory before Dev for Nuxt
#6242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skn0tt
commented
Dec 4, 2023
src/utils/detect-server-settings.ts
Outdated
| const useStaticServer = !(command && frameworkPort) | ||
|
|
||
| // workaround for https://github.com/unjs/nitro/issues/1970 | ||
| const clearDist = frameworkSettings.framework?.includes('Nuxt') |
There was a problem hiding this comment.
I'll be honest, I don't really like that we're storing this within the CLI. Should live within build-info, ideally - let me see if I can open a PR there.
There was a problem hiding this comment.
Here's a PR to add this info to build-info: netlify/build#5430
Turned this into draft until that landed.
5 tasks
|
I couldn't find an easy way of writing a test for this :/ |
Skn0tt
commented
Dec 20, 2023
| @@ -38,12 +41,17 @@ export const startFrameworkServer = async function ({ cwd, settings }) { | |||
| text: `Waiting for framework port ${settings.frameworkPort}. This can be configured using the 'targetPort' property in the netlify.toml`, | |||
| }) | |||
|
|
|||
| if (settings.clearPublishDirectory && settings.dist) { | |||
| await rm(settings.dist, { recursive: true, force: true }) | |||
There was a problem hiding this comment.
this is the main change, all the rest is typescript conversion stuff
There was a problem hiding this comment.
haha I feel you just opened a just change types PR before performing the actual change
lukasholzer
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://linear.app/netlify/issue/COM-184/nuxt-netlify-dev-doesnt-work. Running
ntl buildand thenntl devon a Nuxt project leads to Dev picking updist/_redirectsanddist/_headers, even though the Nitro dev server will handle all of this on its own. This is breaking local dev currently.In unjs/nitro#1970, the Nitro team suggests we add
rm -rfto the dev command. I tried doing that in netlify/build#5429, but since we don't spawn a full shell for the dev process, we can't use command concatenation like&&.This PR contains an alternative fix, where we manually remove the
distdirectory just for Nuxt projects.