Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move compiled artefacts to dist folder #6272

Merged
merged 11 commits into from
Jan 18, 2024

Conversation

lukasholzer
Copy link
Collaborator

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

Moves the compiled artefacts to the dist folder and aligns it with other TypeScript projects at netlify.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

package.json Show resolved Hide resolved
@lukasholzer lukasholzer marked this pull request as draft December 21, 2023 10:22
Copy link

github-actions bot commented Dec 22, 2023

πŸ“Š Benchmark results

Comparing with b6e7e2f

  • Dependency count: 1,294 (no change)
  • Package size: 307 MB ⬇️ 0.00% decrease vs. b6e7e2f
  • Number of ts-expect-error directives: 1,179 ⬇️ 0.08% decrease vs. b6e7e2f

@lemusthelroy
Copy link
Contributor

@lukasholzer I'm taking a look at this as part of CT-312 so will get this branch up to date with the latest changes in main

src/lib/functions/synchronous.ts Dismissed Show dismissed Hide dismissed
@lemusthelroy lemusthelroy marked this pull request as ready for review January 15, 2024 22:30
@lemusthelroy lemusthelroy requested a review from a team as a code owner January 15, 2024 22:30
@lemusthelroy lemusthelroy merged commit 6a20638 into main Jan 18, 2024
37 checks passed
@lemusthelroy lemusthelroy deleted the refactor/move-compiled-artifacts-to-dist branch January 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants