feat: convert status command to clack #6323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemusthelroy
changed the title
khendrikse
requested changes
Jan 17, 2024
src/commands/status/status.ts
Outdated
| log() | ||
| log('Login with "netlify login" command') | ||
| exit() | ||
| NetlifyLog.error(`Not logged in. Please log in to see site status.`) |
There was a problem hiding this comment.
For this one, you might want to add a second parameter with {exit: false} so that line 16 doesn't immediately exit the process. Otherwise line 17 and 18 won't be shown. OR you can change it into a NetlifyLog.warn because it is more informative than actually going wrong :)
I also think we don't need the additional empty one on line 17. I've so far removed all the empty log() ones I've seen.
Then on line 18 you can just use NetlifyLog.message() and then after that you could do outro().
There was a problem hiding this comment.
Awesome, I needed this thank you
src/commands/status/status.ts
Outdated
| @@ -93,5 +91,6 @@ export const status = async (options: OptionValues, command: BaseCommand) => { | |||
| 'Site Id': chalk.yellowBright(siteInfo.id), | |||
| }), | |||
| ) | |||
| log() | |||
| NetlifyLog.message() | |||
There was a problem hiding this comment.
I'd just remove this :)
khendrikse
approved these changes
Jan 17, 2024
lemusthelroy
merged commit b8daf92
into
CP-101/design-system-clack-implementation
30 checks passed
lemusthelroy
deleted the
lemusthelroy/ct-484-convert-status-command-to-clack
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Converts status command to clack
Before:
After:
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)