Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: an issue where the package path was missing when the cwd was not on the root #6404

Merged
merged 1 commit into from Feb 26, 2024

Conversation

lukasholzer
Copy link
Collaborator

πŸŽ‰ Thanks for submitting a pull request! πŸŽ‰

Summary

If you had a monorepo and you did cd apps/my-app and then run ntl build the PACKAGE_PATH was not set which leads to build failures for build plugins that rely on this monorepo configuration.

Now the PACKAGE_PATH constant will be set on those builds as well

Fixes https://linear.app/netlify/issue/FRA-350/enoent-no-such-file-or-directory-open-vartasknextbuild-id


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code πŸ§‘β€πŸ’». This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire πŸ”₯ (e.g. incident related), you can skip this step.
  • Read the contribution guidelines πŸ“–. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) πŸ§ͺ
  • Update or add documentation (if features were changed or added) πŸ“
  • Make sure the status checks below are successful βœ…

A picture of a cute animal (not mandatory, but encouraged)

@lukasholzer lukasholzer requested a review from a team as a code owner February 26, 2024 10:24
Copy link

πŸ“Š Benchmark results

Comparing with acafb49

  • Dependency count: 1,283 (no change)
  • Package size: 282 MB (no change)
  • Number of ts-expect-error directives: 1,180 (no change)

@Skn0tt
Copy link
Member

Skn0tt commented Feb 26, 2024

A test for this would be glamorous!

@lukasholzer
Copy link
Collaborator Author

Already on the test ;)

@lukasholzer lukasholzer merged commit 19184ce into main Feb 26, 2024
36 checks passed
@lukasholzer lukasholzer deleted the fix/fix-missing-package-path-when-cd-in-monorepo branch February 26, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants