fix: use the right Blobs context in serve
#6506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Apr 10, 2024
| @@ -143,6 +157,7 @@ export const serve = async (options: OptionValues, command: BaseCommand) => { | |||
| const inspectSettings = generateInspectSettings(options.edgeInspect, options.edgeInspectBrk) | |||
| const url = await startProxyServer({ | |||
| addonsUrls, | |||
| blobsContext: runtimeBlobsContext, | |||
There was a problem hiding this comment.
This was missing entirely, so edge functions were not getting a Blobs context.
Skn0tt
previously approved these changes
Apr 10, 2024
Skn0tt
approved these changes
Apr 10, 2024
JGAntunes
approved these changes
Apr 10, 2024
|
Superseded by #6507. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
netlify serveis a bit special in that it first runs a build and then starts a server. In production, these steps have different Blobs contexts — API access should be used at build time and edge access should be used at runtime. This PR makes theservecommand respect that.Part of COM-580.