Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update actions/upload-artifact action to v4 #6569

Merged
merged 4 commits into from
May 14, 2024
Merged

chore(deps): update actions/upload-artifact action to v4 #6569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67181e7
chore(deps): update actions/upload-artifact action to v4
renovate[bot] May 9, 2024
0da54b3
chore: prevent duplicate report names
mrstork May 9, 2024
b869c7f
chore: include explicit codecov token
mrstork May 9, 2024
b28fafa
Merge branch 'main' into renovate/major-github-artifact-actions
mrstork May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
if: github.event_name == 'pull_request'
run: echo ${{ github.event.number }} > ./pr_number
- name: Upload deltas
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: delta-action-deltas
retention-days: 7
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/integration-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,16 +104,22 @@ jobs:
echo "node=node_${node/.*.*/}" >> $env:GITHUB_OUTPUT
shell: bash
if: '${{ !steps.release-check.outputs.IS_RELEASE }}'

- name: Sanitize shard for artefact name
id: sanitize-shard-name
run: echo "shard=$(echo '${{ matrix.shard }}' | tr '/' '-')" >> $GITHUB_OUTPUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub doesn't allow / in the file name (see L116)


- name: Store npm error artefacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: always()
with:
name: npm-logs
name: npm-logs--${{ matrix.os }}--${{ matrix.node-version }}--${{ steps.sanitize-shard-name.outputs.shard }}
path: |
/home/runner/.npm/_logs/**/*

- uses: codecov/codecov-action@v4
continue-on-error: true
with:
flags: ${{ steps.test-coverage-flags.outputs.os }},${{ steps.test-coverage-flags.outputs.node }}
token: ${{ secrets.CODECOV_TOKEN }}
Copy link
Contributor

@mrstork mrstork May 10, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not being picked up, could we make sure it hasn't accidentally been removed? (I don't have permissions to view)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this secret has ever existed - I think this PR is trying to tell us that we need one now with the newest version?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an account for https://app.codecov.io/gh/netlify/cli? Can we retrieve a token from that account? Otherwise I can downgrade us back to codecov/codecov-action@v3 (where the token isn't required for the workflow step). There might be a case to be made for removing the codecov step completely as it doesn't seem to be very depended on, though you folks would have more context on that topic.

if: '${{ !steps.release-check.outputs.IS_RELEASE }}'