fix: adds html injections to dev proxy [CRE-1203] #6686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnh
changed the title
smnh
commented
Jun 3, 2024
| @@ -7,7 +7,6 @@ import { format } from 'util' | |||
|
|
|||
| import { DefaultLogger, Project } from '@netlify/build-info' | |||
| import { NodeFS, NoopLogger } from '@netlify/build-info/node' | |||
| // @ts-expect-error TS(7016) FIXME: Could not find a declaration file for module '@net... Remove this comment to see the full error message | |||
| import { resolveConfig } from '@netlify/config' | |||
There was a problem hiding this comment.
This is fixed by this:
netlify/build@cf45931
smnh
commented
Jun 3, 2024
| @@ -1,6 +1,5 @@ | |||
| import process from 'process' | |||
|
|
|||
| // @ts-expect-error TS(7016) FIXME: Could not find a declaration file for module '@net... Remove this comment to see the full error message | |||
| import { applyMutations } from '@netlify/config' | |||
There was a problem hiding this comment.
This is fixed by this:
netlify/build@cf45931
smnh
commented
Jun 3, 2024
Comment on lines
63
to
+64
| case 'deflate': | ||
| return await deflate(body) | ||
| return await inflate(body) |
There was a problem hiding this comment.
inflate is for decompressing.
deflate is for compressing.
There was a problem hiding this comment.
Why is the case deflate?
There was a problem hiding this comment.
@smnh I think the PR is ready to merge, just curious about this last point. If case "deflate": return inflate is intentional I think adding a code comment about why we handle the "deflate" case with "inflate" is a good idea here
smnh
force-pushed
the
create-on-dev-server-CRE-1203
branch
from
2655990
to
67a057d
Compare
smnh
force-pushed
the
create-on-dev-server-CRE-1203
branch
from
67a057d
to
bd7ed65
Compare
TylerBarnes
reviewed
Jun 3, 2024
TylerBarnes
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables visual-editor plugin to inject snippet into html in dev mode.
Related PRs: