🐛 Fix a loop for setting env vars #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaeesBhatti
changed the title
This was referenced Mar 13, 2020
ehmicky
reviewed
Mar 13, 2020
| @@ -64,6 +64,49 @@ test.serial('netlify dev functions timeout', async t => { | |||
| }) | |||
| }) | |||
|
|
|||
| test('netlify dev env file', async t => { | |||
| let data = "" | |||
| await new Promise((resolve, reject) => { | |||
There was a problem hiding this comment.
Small detail: using a HTTP client library like got might help remove some lines of code.
There was a problem hiding this comment.
One thing at a time 😊
ehmicky
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes: #747
- Test plan
.envfile in your project rootnetlify dev- Description for the changelog
Object.entriesinstead ofObject.values🤦🏽♂️- A picture of a cute animal (not mandatory but encouraged)
🙈