Dev: Pass .env vars as an object to child process #764
Conversation
src/commands/dev/index.js
Outdated
| @@ -424,6 +424,7 @@ class DevCommand extends Command { | |||
| const envFile = path.resolve(site.root, '.env') | |||
| if (fs.existsSync(envFile)) { | |||
| const vars = dotenv.parse(fs.readFileSync(envFile)) || {} | |||
| settings.env = { ...settings.env, ...vars } | |||
| console.log(`${NETLIFYDEVLOG} Overriding the following env variables with ${chalk.blue('.env')} file:`, chalk.yellow(Object.keys(vars))) | |||
| Object.entries(vars).forEach(([key, val]) => process.env[key] = val) | |||
There was a problem hiding this comment.
process.env[key] being set here. Is not accessible two lines down when accessed in startDevServer.
cc @erquhart
There was a problem hiding this comment.
The cause for this bug is the spread order of properties here:
Line 341 in 3085892
settings.env properties override process.env properties.
Changing that line to env: { ...settings.env,...process.env, FORCE_COLOR: 'true' }, fixes it
RaeesBhatti
force-pushed
the
raees/env-fix
branch
from
a3a26f5
to
519c81b
Compare
|
Ah I see. Thanks a bunch @erezrokah. This was a head scratcher. I never looked at the detectors logic, I thought they only returned application specific env variables. |
|
Can you please take another look @erezrokah |
|
Sure, reviewing now |
|
Yeah. All of the detectors inherit |
- Summary
This is to fix an inconsistency in NodeJS which results in
process.envnot realizing changes if they're accessed shortly after.Fixes: #747
- Test plan
create-react-appproject connected to Netlify production withnetlify link..envfile in project root locally that overrides that env variablenetlify devand observe the value of that env variable- Description for the changelog
Pass the variables from
.envfile assetting.envobject tostartDevServer, so that, they're set explicitly on the new process.- A picture of a cute animal (not mandatory but encouraged)
馃惓