Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade firebase to 7 #790

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Upgrade firebase to 7 #790

merged 1 commit into from
Apr 3, 2020

Conversation

RaeesBhatti
Copy link
Contributor

- Summary
Fixes: #769

- Test plan
npm i on with Node 13

- Description for the changelog
Upgrade firebase to 7

- A picture of a cute animal (not mandatory but encouraged)
馃

@RaeesBhatti RaeesBhatti requested a review from ehmicky April 3, 2020 18:07
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works! 馃帀

@RaeesBhatti RaeesBhatti merged commit 072e3cf into master Apr 3, 2020
@RaeesBhatti RaeesBhatti deleted the raees/upgrade-firebase branch April 3, 2020 18:34
RaeesBhatti added a commit that referenced this pull request Apr 8, 2020
RaeesBhatti added a commit that referenced this pull request Apr 8, 2020
RaeesBhatti added a commit that referenced this pull request Apr 8, 2020
* Revert "Upgrade firebase to 7 (#790)"

This reverts commit 072e3cf.

* Revert "Upgrade firebase (#789)"

This reverts commit c9b49b0.

* Revert "Add support for getting/tailing deploy logs (#762)"

This reverts commit ac123da.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to install on Node >=12 on Linux
2 participants