chore!: use pure ES modules #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Dec 7, 2021
| @@ -60,7 +63,7 @@ | |||
| "@commitlint/cli": "^15.0.0", | |||
| "@commitlint/config-conventional": "^15.0.0", | |||
| "@netlify/eslint-config-node": "^4.0.0", | |||
| "ava": "^2.4.0", | |||
| "ava": "^3.0.0", | |||
There was a problem hiding this comment.
This is needed to support pure ES modules.
ehmicky
force-pushed
the
chore/pure-esm
branch
2 times, most recently
from
6d56cda
to
7ea3db1
Compare
Co-authored-by: Renovate Bot <bot@renovateapp.com>
ehmicky
force-pushed
the
chore/pure-esm
branch
from
7ea3db1
to
0c56684
Compare
|
Thanks! Could you please re-review it? There was a merge conflict. |
lukasholzer
approved these changes
Dec 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/netlify/team-dev/issues/36
This switches from CommonJS to pure ES modules.
This is a breaking change, since consumers that still use CommonJS will need to use a dynamic
import()to load this module instead ofrequire(). Consumers that use pure ES modules will not need to change anything.However, in practice, this repository is not loaded programmatically but as a GitHub action.
esbuildis bundling this to CommonJS. So we should be able to make a minor release, but let's go with a major release just to be safe.