Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno binary download issue #6

Closed
louis-bompart opened this issue Apr 19, 2022 · 4 comments
Closed

Deno binary download issue #6

louis-bompart opened this issue Apr 19, 2022 · 4 comments
Assignees
Labels
type: bug code to address defects in shipped code

Comments

@louis-bompart
Copy link

Describe the bug

When deno is not installed globally, edge-bundler download it and then and try to run deno --version (using the downloaded version).
However, edge-bundler does not wait for the binary to be 'free' by the operating system, which can lead to EBUSY1 error.

Configuration

  System:
    OS: Windows 10 10.0.19044
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 21.94 GB / 31.91 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    npm: 8.6.0 - ~\AppData\Roaming\npm\npm.CMD

Pull requests

🔜

Footnotes

  1. https://nodejs.org/dist/latest-v16.x/docs/api/all.html#all_os_posix-error-constants

@louis-bompart louis-bompart added the type: bug code to address defects in shipped code label Apr 19, 2022
@louis-bompart
Copy link
Author

louis-bompart commented Apr 19, 2022

I think the issue is mainly due to anti-viruses flagging deno on the first run or so.

@minivan
Copy link
Contributor

minivan commented Jun 24, 2022

hi @louis-bompart ! this should be fixed in the newest release of the edge bundler, can you try and see if it works for you? Thank you!

@jackiewmacharia
Copy link
Contributor

Closing this. In case of additional issues, let us know in subsequent comments and we'll get to it.

@louis-bompart
Copy link
Author

Hi, sorry for the late answer, I just tested the latest release, I can confirm that the issue has been mitigated ✅ thanks!

Skn0tt pushed a commit to netlify/build that referenced this issue Apr 23, 2024
Skn0tt pushed a commit to netlify/build that referenced this issue Apr 23, 2024
* refactor: rename variable

* feat: add support for user import maps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

No branches or pull requests

3 participants