Use referrer to determine URL sent in emails #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcomnes
reviewed
Feb 9, 2018
| if reqref := r.Referer(); reqref != "" { | ||
| base, berr := url.Parse(config.SiteURL) | ||
| refurl, rerr := url.Parse(reqref) | ||
| // As long as the referrer came from the site, we will redirect back there |
There was a problem hiding this comment.
What do you mean?
There was a problem hiding this comment.
If you try to log in from a site running on localhost, will the confirm emails pick that up in the redirect they send you?
There was a problem hiding this comment.
Only if the site URL is also localhost
bcomnes
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Fixes #112
- Test plan
Added tests for email URL generation function w/ referrer included.
- Description for the changelog
Use referrer to determine URL sent in emails.