Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump Inline Critical CSS to v2.0.0 #530

Merged
merged 1 commit into from
Dec 13, 2021
Merged

feat: bump Inline Critical CSS to v2.0.0 #530

merged 1 commit into from
Dec 13, 2021

Conversation

Tom-Bonnike
Copy link
Contributor

@Tom-Bonnike Tom-Bonnike commented Dec 12, 2021

Are you adding a plugin or updating one?

Have you completed the following?

Test plan

https://app.netlify.com/sites/tombonnike/deploys/61b5fbfb7529a50008e2ce90

@netlify-bot
Copy link
Collaborator

},
{
"version": "1.2.0",
"nodeVersion": "TBD"
Copy link
Contributor Author

@Tom-Bonnike Tom-Bonnike Dec 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m unsure what I should put here? v2.0.0 contains a critical major version update that drops support for Node v11 and v13, but before that any version superior to 10.3.0 would work. @ehmicky any clue?

Copy link
Contributor

@ehmicky ehmicky Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"nodeVersion": "TBD"
"nodeVersion": "^11 || ^13"

I believe this is the change, is this correct? If so, 1.2.0 should be used instead of 2.0.0 for sites with Node 11 or 13.

Please note that sites currently using 1.2.0 will keep doing so until the user has explicitly upgraded the plugin in the UI (if the plugin was installed in the UI).

Copy link
Contributor Author

@Tom-Bonnike Tom-Bonnike Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is the change, is this correct?

Yes.

If so, 1.2.0 should be used instead of 2.0.0 for sites with Node 11 or 13.

Ahh, took me a while but yes, that should do it. Thanks! Then anyone on Node 10, 12 or 14 should use 2.0.0, correct!

Please note that sites currently using 1.2.0 will keep doing so until the user has explicitly upgraded the plugin in the UI (if the plugin was installed in the UI).

Understood! 👍

@ehmicky
Copy link
Contributor

ehmicky commented Dec 13, 2021

This looks good. Thanks @Tom-Bonnike!

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Dec 13, 2021
@ehmicky ehmicky changed the title Bump Inline Critical CSS to v2.0.0 feat: bump Inline Critical CSS to v2.0.0 Dec 13, 2021
@ehmicky ehmicky added type: chore work needed to keep the product and development running smoothly type: feature code contributing to the implementation of a feature and/or user facing functionality and removed type: chore work needed to keep the product and development running smoothly labels Dec 13, 2021
@Tom-Bonnike Tom-Bonnike changed the title feat: bump Inline Critical CSS to v2.0.0 Bump Inline Critical CSS to v2.0.0 Dec 13, 2021
@Tom-Bonnike Tom-Bonnike changed the title Bump Inline Critical CSS to v2.0.0 feat: bump Inline Critical CSS to v2.0.0 Dec 13, 2021
@ehmicky ehmicky merged commit 62dac30 into netlify:main Dec 13, 2021
@Tom-Bonnike Tom-Bonnike deleted the patch-1 branch December 13, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants