-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump Inline Critical CSS to v2.0.0 #530
Conversation
site/plugins.json
Outdated
}, | ||
{ | ||
"version": "1.2.0", | ||
"nodeVersion": "TBD" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"nodeVersion": "TBD" | |
"nodeVersion": "^11 || ^13" |
I believe this is the change, is this correct? If so, 1.2.0
should be used instead of 2.0.0
for sites with Node 11 or 13.
Please note that sites currently using 1.2.0
will keep doing so until the user has explicitly upgraded the plugin in the UI (if the plugin was installed in the UI).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is the change, is this correct?
Yes.
If so, 1.2.0 should be used instead of 2.0.0 for sites with Node 11 or 13.
Ahh, took me a while but yes, that should do it. Thanks! Then anyone on Node 10, 12 or 14 should use 2.0.0, correct!
Please note that sites currently using 1.2.0 will keep doing so until the user has explicitly upgraded the plugin in the UI (if the plugin was installed in the UI).
Understood! 👍
This looks good. Thanks @Tom-Bonnike! |
Are you adding a plugin or updating one?
Have you completed the following?
Test plan
https://app.netlify.com/sites/tombonnike/deploys/61b5fbfb7529a50008e2ce90