-
Notifications
You must be signed in to change notification settings - Fork 35
Strange bundling error when including sub directory #16
Comments
hmm, where's the |
No idea. I'm just importing
The modules aren't corrupted, the functions deploy fine if they don't require files from sibling folders. I ended up hoisting everything to the parent folder for now to get around this |
Did this get fixed? |
Not yet. I fixed this by reorganizing my file structure. Seemed like module resolution was not looking in sibling folder for dep. Which I think is the correct behavior. Haven't see this issue since I reorganized my files |
Also having this issue now, but it started from nothing, no change to netlify functions codebase whatsoever. In fact deploy previews were passing without issues and when it got merged to production, this poped up. |
The solution is to install |
Bump. Also ran into this issue with |
Workaround for node-fetch issue (netlify/zip-it-and-ship-it#16)
This should be fixed by d3e4b2a, please let us know if this is still happening. |
Just happened to me on a preview deployment with |
Hi I'm encountering a similar error (not
More info in this comment from @kamilmysliwiec (creator of NestJS) in this thread : nestjs/nest#1706 (comment) TLDR :
From what I saw later in the thread, there are potentially other lazy imports :
Is there a way to tell Installing all those peerDependencies as suggested by @bcomnes #16 (comment) could work, but there are plenty + not sure this is an exhaustive list (could break anytime if NestJS code evolves) |
Hi @jon301 and @polarbirke. I've just made a new release. Could you please check if it now works? Also you should see the following line in your log:
If not, please let me know. Thanks! |
Hi @ehmicky, thanks for checking this out
|
Can you try again? You should now see:
And your initial issue should now be solved. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Tried just now and still with old version :(
|
Hi @ehmicky , thanks for your help
Edit : I think it's because of this line : https://github.com/ardatan/graphql-toolkit/blob/master/packages/loaders/code-file/src/extract-document-string-from-code-file.ts#L52 |
Since that's a separate issue, I have opened a new issue at #66. It looks like the original issue is solved. Please let me know if this appears again. |
This issue is symptomatic of a more general problem described at #68. Please refer to this issue for further discussion. |
Thanks - ran into this issue. Resolved. |
Including a file from a sub folder is crashing my
netlify deploy
with this errorThe file is in a sub folder and has all the dependancies installed locally.
Here is the dep tree
I'm using
node-fetch
as a dependancy in the/functions/customerio/api/index.js
fileThe text was updated successfully, but these errors were encountered: