Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Filter unnecessary files out of Netlify Functions #109

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Filter unnecessary files out of Netlify Functions #109

merged 1 commit into from
Jun 1, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 7, 2020 •
edited
Loading

Fixes #108.

To keep Netlify Functions small, the following files should not be bundled:

  • temporary files: *.swp
  • backup files: *~
  • dump files: npm-debug.log
  • filesystem metadata:
    • Mac: .DS_Store, .AppDouble, .LSOverride, Icon, ._.*, .Spotlight-V100*, __MACOSX
    • Windows: Thumbs.db, ehthumbs.db, Desktop.ini, @eaDir

The junk library checks that.

@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 7, 2020
@ehmicky ehmicky requested a review from erezrokah May 7, 2020 16:20
@ehmicky ehmicky self-assigned this May 7, 2020
@ehmicky ehmicky mentioned this pull request May 7, 2020
Closed
@ehmicky ehmicky requested review from erezrokah and removed request for erezrokah June 1, 2020 12:28
erezrokah
erezrokah approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should probably support opting out or enabling exclude/include patterns (couldn't figure out if we support it), but that is another feature all together

@ehmicky
Copy link
Contributor Author

ehmicky commented Jun 1, 2020

👍
This is currently tracked by the following issue: #68 (comment)

@ehmicky ehmicky merged commit ba4b0ea into master Jun 1, 2020
@ehmicky ehmicky deleted the feat/smaller-functions branch June 1, 2020 12:42
@internetbuilder internetbuilder mentioned this pull request Oct 23, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees

@ehmicky ehmicky

Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove temporary files from bundled Functions
2 participants
@ehmicky @erezrokah