Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min/max definitions in xpl.h #49

Closed
petehug opened this issue Sep 23, 2015 · 2 comments
Closed

min/max definitions in xpl.h #49

petehug opened this issue Sep 23, 2015 · 2 comments

Comments

@petehug
Copy link
Contributor

petehug commented Sep 23, 2015

These definitions can cause a headache in some situations. In some build environments, I need to include standard library files before I (directly or indirectly) include xpl.h.

I suggest changing these macros to XPL_MIN and XPL_MAX to avoid conflicts.

@penduin
Copy link
Member

penduin commented Sep 30, 2015

I wonder if we could have those get defined only conditionally, if they're not defined already. Depending on what and how you're building that still might not be helpful, of course.

Switching to an internal and unlikely-to-clash symbol should be easy enough. (Either for me or for somebody who wanted to post a patch and/or pull request :^)

HugoKlepsch pushed a commit to HugoKlepsch/wjelement that referenced this issue Nov 14, 2017
* Addresses issue netmail-open#49
* Renamed to xpl_min and xpl_max
@penduin
Copy link
Member

penduin commented Nov 14, 2017

@HugoKlepsch for the win. :^) My apologies if anyone has been waiting on this.

@penduin penduin closed this as completed Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants