NETOBSERV-765 Restore metrics

[jotak]

No description provided.

[jotak]

Hey @OlivierCazade @jpinsonneau ,
I'm not 100% decided on what to do here. Those metrics don't carry any sensitive data. It's not like FLP metrics.
The alternative could be to cover /metrics with AuthChecker, which would require a bearer token config in ServiceMonitor.

[jpinsonneau]

The alternative could be to cover /metrics with AuthChecker, which would require a bearer token config in ServiceMonitor.

How hard is it to implement ?

[OlivierCazade]

There should be changes in go.mod and go.sum files right?

[OlivierCazade]

Another possibility would be to serve the metrics on a different port.

[jotak]

There should be changes in go.mod and go.sum files right?

No change there, prometheus is already imported, there's just a couple more files being used hence added to vendors

[jotak]

@OlivierCazade I implemented your suggestion; see also netobserv/network-observability-operator#310

[codecov]

Codecov Report

Merging #315 (4196fcb) into main (2a47af3) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   58.31%   58.08%   -0.24%     
==========================================
  Files         148      149       +1     
  Lines        6592     6615      +23     
  Branches      792      792              
==========================================
- Hits         3844     3842       -2     
- Misses       2531     2556      +25     
  Partials      217      217              

Flag	Coverage Δ
uitests	58.97% <ø> (ø)
unittests	55.56% <0.00%> (-0.87%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/plugin-backend.go	0.00% <0.00%> (ø)
pkg/server/metrics_server.go	0.00% <0.00%> (ø)
pkg/server/routes.go	89.65% <ø> (-0.67%)	⬇️

[memodi]

/ok-to-test

[github-actions]

New image: ["quay.io/netobserv/network-observability-console-plugin:59a7515"]. It will expire after two weeks.

[memodi]

@jotak - I tested this with plugin image listed here and used NOO image from PR: netobserv/network-observability-operator#310. I enabled user workload monitoring, but I am not able to see plugin metrics being scraped, in below screenshot you can find metrics from just FLP container, anything I am missing?

[OlivierCazade]

LGTM

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jotak]

@memodi I retried this morning and it worked for me. Same steps as you: deploy my operator PR image, set this console plugin image, enable user workload monitoring... wait a minute or so to get metrics populated, and they are:

Also if you trigger some queries to Loki via the console plugin, you should get dedicated metrics such as netobserv_http_api_calls_duration_bucket

If you retry, could you check the Targets page to see if the console plugin is listed and w/o errors?
E.g:

[github-actions]

New image: ["quay.io/netobserv/network-observability-console-plugin:9bfd9ec"]. It will expire after two weeks.

[memodi]

yes, I can see those metrics today. Not sure what I had missed other day. Anyway, thank you for checking.

/label qe-approved

[jotak]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jotak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment