NETOBSERV-765 Add CA/Secret config to ServiceMonitor #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotak
commented
Mar 29, 2023
| @@ -532,7 +532,7 @@ type FlowCollectorConsolePlugin struct { | |||
| //+kubebuilder:validation:Minimum=1 | |||
| //+kubebuilder:validation:Maximum=65535 | |||
| //+kubebuilder:default:=9001 | |||
| // port is the plugin service port | |||
| // port is the plugin service port. Do not use 9002, which is reserved for metrics. | |||
There was a problem hiding this comment.
Note: I didn't want to add a new port config to the CRD, I think it brings very little value if any, while bloating the CRD with new configs ...
There was a problem hiding this comment.
do we need a //+kubebuilder:validation to exclude 9002 ? Maybe using a pattern
There was a problem hiding this comment.
@jotak while we're at it, do you think it would be good idea to address this: https://issues.redhat.com/browse/NETOBSERV-511 ?
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 51.34% 51.53% +0.18%
==========================================
Files 43 43
Lines 5155 5156 +1
==========================================
+ Hits 2647 2657 +10
+ Misses 2310 2304 -6
+ Partials 198 195 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
OlivierCazade
previously approved these changes
Mar 30, 2023
jpinsonneau
previously approved these changes
Mar 31, 2023
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-bca9db7
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
Add missing CA/Secret to the console plugin service monitor
Some refactoring to normalize services reconciliation
github-actions
bot
removed
the
ok-to-test
jotak
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-7fe73cd
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing CA/Secret to the console plugin service monitor
Cf netobserv/network-observability-console-plugin#315
We might also want to add a bearer token config