NETOBSERV-971 Fix couple of CRD issues on zero-values #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Nice catch, but I would suggest a different fix.
We have many others bool in the API and removing all of them the omitempty flag would create a lot of unnecessary mandatory fields.
After some test it would also work if we let the omitempty flag but swithc to a bool pointer.
The downside is we would have to check for nil each time which can be done in a sugar function but the good side is that we would keep the field optional in the API.
jotak
changed the title
|
@OlivierCazade I reviewed the whole CRD ... which leads to a bigger pull request |
Codecov Report
@@ Coverage Diff @@
## main #319 +/- ##
==========================================
+ Coverage 50.90% 51.34% +0.44%
==========================================
Files 43 43
Lines 5080 5155 +75
==========================================
+ Hits 2586 2647 +61
- Misses 2293 2310 +17
+ Partials 201 198 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
OlivierCazade
previously approved these changes
Apr 4, 2023
msherif1234
reviewed
Apr 4, 2023
|
/lgtm |
|
/approve |
jotak
added
ok-to-test
|
/approve cancel |
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-908f029
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
jotak
force-pushed
the
portname-omitempy
branch
from
6992083
to
b30f2bf
Compare
github-actions
bot
removed
the
ok-to-test
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New images:
They will expire after two weeks. Catalog source: apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
metadata:
name: netobserv-dev
namespace: openshift-marketplace
spec:
sourceType: grpc
image: quay.io/netobserv/network-observability-operator-catalog:v0.0.0-32a550d
displayName: NetObserv development catalog
publisher: Me
updateStrategy:
registryPoll:
interval: 1m |
|
/label qe-approved |
OlivierCazade
previously approved these changes
Apr 24, 2023
CRD cleanup / sanitizing Find & fix a bunch of CRD issues where go zero-value was conflicting with CRD default. The typical workaround is to use pointers or, for lists and maps, remove "omitempty". Add a test to help catch these issues Found issues: - portNamings.enable (this was the original issue) - portNamings.portNames (could not set empty list) - ebpf.interfaces and excludeInterfaces (e.g. could not set empty exclusion list) - processor.metrics.ignoreTags and disableAlerts (could not set empty ignoreTags) - processor.enableKubeProbles, dropUnusedFields (could not set false) - processor.kafkaConsumerReplicas (could not set 0) - loki.maxRetries (could not set 0) - loki.staticLabels (could not set empty list) - plugin.register (could not set false) - plugin.replicas (could not set 0) - plugin.quickFilters (could not set empry list)
jpinsonneau
force-pushed
the
portname-omitempy
branch
from
b30f2bf
to
6948a3a
Compare
|
New changes are detected. LGTM label has been removed. |
github-actions
bot
removed
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpinsonneau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CRD cleanup / sanitizing
Find & fix a bunch of CRD issues where go zero-value was conflicting
with CRD default. The typical workaround is to use pointers or, for
lists and maps, remove "omitempty".
Add a test to help catch these issues
Found issues:
list)
ignoreTags)