Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-140 & NETOBSERV-141 Top pod / service talkers #392

Closed
wants to merge 3 commits into from

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jul 7, 2023

@openshift-ci
Copy link

openshift-ci bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #392 (b922e2d) into main (0d6ebe8) will increase coverage by 2.31%.
Report is 4 commits behind head on main.
The diff coverage is 82.63%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   53.67%   55.99%   +2.31%     
==========================================
  Files          44       45       +1     
  Lines        5559     5915     +356     
==========================================
+ Hits         2984     3312     +328     
- Misses       2359     2383      +24     
- Partials      216      220       +4     
Flag Coverage Δ
unittests 55.99% <82.63%> (+2.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
api/v1alpha1/zz_generated.conversion.go 0.25% <0.00%> (-0.01%) ⬇️
api/v1beta1/flowcollector_types.go 100.00% <ø> (ø)
controllers/flowlogspipeline/flp_reconciler.go 67.85% <ø> (-5.32%) ⬇️
controllers/flowcollector_controller.go 53.71% <20.00%> (-1.41%) ⬇️
controllers/flowlogspipeline/flp_common_objects.go 82.32% <71.50%> (+0.56%) ⬆️
...ntrollers/flowlogspipeline/flp_monolith_objects.go 88.46% <75.00%> (ø)
...ontrollers/flowlogspipeline/flp_transfo_objects.go 93.68% <75.00%> (ø)
controllers/flowcollector_objects.go 46.91% <77.77%> (+9.62%) ⬆️
pkg/helper/dashboard.go 96.91% <96.91%> (ø)
api/v1beta1/zz_generated.deepcopy.go 55.36% <100.00%> (+1.58%) ⬆️
... and 6 more

@jpinsonneau jpinsonneau requested a review from jotak July 7, 2023 09:29
@jpinsonneau jpinsonneau marked this pull request as ready for review July 7, 2023 09:29
@jpinsonneau
Copy link
Contributor Author

/hold

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jpinsonneau
Copy link
Contributor Author

Needs to be refactored
Also waiting for #391 (comment) feedback before doing so

@jpinsonneau
Copy link
Contributor Author

Closing this in favor of allow list + metrics generation refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants